Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 2747333006: Modify paint/invalidation/compositing/scrolling-neg-z-index-descendants-should-cause-repaint-expect… (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
wkorman
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify paint/invalidation/compositing/scrolling-neg-z-index-descendants-should-cause-repaint-expected.html to show bug Previously the test was written in a way to hide the bug. It only checked paint invalidation of the scrollbar. We miss paint invalidation of the contents. Convert the test into a text-based-repaint test, and move it to paint/invalidation/compositing. BUG=702006 Review-Url: https://codereview.chromium.org/2747333006 Cr-Commit-Position: refs/heads/master@{#457583} Committed: https://chromium.googlesource.com/chromium/src/+/5db93ce184722588b24a21fc2f9c53b16cf9a45b

Patch Set 1 #

Patch Set 2 : Correct TestExpectations #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -121 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/scrolling-neg-z-index-descendants-should-cause-repaint.html View 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/scrolling-neg-z-index-descendants-should-cause-repaint-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/scrolling-neg-z-index-descendants-should-cause-repaint.html View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/scrolling-neg-z-index-descendants-should-cause-repaint-expected.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/compositing/scrolling-neg-z-index-descendants-should-cause-repaint-expected.txt View 1 chunk +45 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/compositing/overflow/scrolling-neg-z-index-descendants-should-cause-repaint-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scrolling-neg-z-index-descendants-should-cause-repaint-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scrolling-neg-z-index-descendants-should-cause-repaint-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Xianzhu
3 years, 9 months ago (2017-03-15 23:48:00 UTC) #4
wkorman
lgtm
3 years, 9 months ago (2017-03-16 18:33:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747333006/20001
3 years, 9 months ago (2017-03-16 20:06:36 UTC) #10
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-16 21:14:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747333006/40001
3 years, 9 months ago (2017-03-16 21:17:38 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 22:21:12 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5db93ce184722588b24a21fc2f9c...

Powered by Google App Engine
This is Rietveld 408576698