Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: third_party/WebKit/Source/core/dom/Document.idl

Issue 2747333003: Make Document.createTouch arguments non-optional (Closed)
Patch Set: Codereview: update tests as suggested Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.idl
diff --git a/third_party/WebKit/Source/core/dom/Document.idl b/third_party/WebKit/Source/core/dom/Document.idl
index 8b3ae3e71b25e99932fb891d427cfb90e5922f57..68a3907d9215aa857f098c0365f1fb9457f5e0e2 100644
--- a/third_party/WebKit/Source/core/dom/Document.idl
+++ b/third_party/WebKit/Source/core/dom/Document.idl
@@ -156,19 +156,18 @@ interface Document : Node {
// Touch Events
// https://w3c.github.io/touch-events/#extensions-to-the-document-interface
- // FIXME: The arguments should not be optional.
[RuntimeEnabled=TouchEventFeatureDetection, Measure, LegacyInterfaceTypeChecking, Custom=CallPrologue]
- Touch createTouch([Default=Undefined] optional Window window,
- [Default=Undefined] optional EventTarget target,
- [Default=Undefined] optional long identifier,
- [Default=Undefined] optional unrestricted double pageX,
- [Default=Undefined] optional unrestricted double pageY,
- [Default=Undefined] optional unrestricted double screenX,
- [Default=Undefined] optional unrestricted double screenY,
- [Default=Undefined] optional unrestricted double radiusX,
- [Default=Undefined] optional unrestricted double radiusY,
- [Default=Undefined] optional unrestricted float rotationAngle,
- [Default=Undefined] optional unrestricted float force);
+ Touch createTouch(Window view,
+ EventTarget target,
+ long identifier,
+ double pageX,
+ double pageY,
+ double screenX,
+ double screenY,
+ optional unrestricted double radiusX = 0,
+ optional unrestricted double radiusY = 0,
+ optional unrestricted float rotationAngle = 0,
+ optional unrestricted float force = 0);
[RuntimeEnabled=TouchEventFeatureDetection] TouchList createTouchList(Touch... touches);
// Custom Elements
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698