third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html - Issue 2747333003: Make Document.createTouch arguments non-optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html

Issue 2747333003: Make Document.createTouch arguments non-optional (Closed)

Patch Set: Codereview: update tests as suggested Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-expected.txt ('k') | third_party/WebKit/Source/core/dom/Document.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html b/third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html

index 12de76a2b005fb9dcbcb9d61246b802f079bdda7..8a72f752b781b0cbfedbb69640be1cb5218fe05c 100644

--- a/third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html

+++ b/third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html

@@ -7,7 +7,7 @@

description('Test that touches created with no target does not crash during dispatch. http://crbug.com/517962');

var event = new TouchEvent('touchstart', {

- touches: [document.createTouch()],

+ touches: [document.createTouch(window, null, 0, 0, 0, 0, 0)],

});

document.body.dispatchEvent(event);