Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2874)

Unified Diff: mojo/services/view_manager/view_manager_connection_unittest.cc

Issue 274733004: Deletion/ownership (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/view_manager/view_manager_connection.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/view_manager/view_manager_connection_unittest.cc
diff --git a/mojo/services/view_manager/view_manager_connection_unittest.cc b/mojo/services/view_manager/view_manager_connection_unittest.cc
index dea435b03ba1720c8dbc0004307abe86ed514e9c..48c520d247679febb39193ed19e199f785c0521b 100644
--- a/mojo/services/view_manager/view_manager_connection_unittest.cc
+++ b/mojo/services/view_manager/view_manager_connection_unittest.cc
@@ -223,6 +223,14 @@ class ViewManagerClientImpl : public IViewManagerClient {
NodeIdToString(old_view_id).c_str()));
QuitIfNecessary();
}
+ virtual void OnNodeDeleted(TransportNodeId node,
+ TransportChangeId change_id) OVERRIDE {
+ changes_.push_back(
+ base::StringPrintf(
+ "change_id=%d node=%s deleted",
+ static_cast<int>(change_id), NodeIdToString(node).c_str()));
+ QuitIfNecessary();
+ }
void QuitIfNecessary() {
if (quit_count_ > 0 && --quit_count_ == 0)
@@ -445,11 +453,12 @@ TEST_F(ViewManagerConnectionTest, DeleteNode) {
CreateNodeId(client_.id(), 1),
121));
Changes changes(client_.GetAndClearChanges());
- ASSERT_EQ(2u, changes.size());
+ ASSERT_EQ(3u, changes.size());
EXPECT_EQ("change_id=121 node=1,1 new_parent=null old_parent=0,1",
changes[0]);
EXPECT_EQ("change_id=121 node=1,2 new_parent=null old_parent=1,1",
changes[1]);
+ EXPECT_EQ("change_id=121 node=1,1 deleted", changes[2]);
}
}
@@ -507,9 +516,10 @@ TEST_F(ViewManagerConnectionTest, DeleteNodeWithView) {
CreateNodeId(client_.id(), 1),
121));
Changes changes(client_.GetAndClearChanges());
- ASSERT_EQ(1u, changes.size());
+ ASSERT_EQ(2u, changes.size());
EXPECT_EQ("change_id=121 node=1,1 new_view=null old_view=1,11",
changes[0]);
+ EXPECT_EQ("change_id=121 node=1,1 deleted", changes[1]);
}
// Set view 11 on node 2.
« no previous file with comments | « mojo/services/view_manager/view_manager_connection.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698