Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Issue 2747253004: Implement (FORMAT_ELAPSED, LENGTH_LONG) in time_format (Closed)

Created:
3 years, 9 months ago by Olivier
Modified:
3 years, 9 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, srahim+watch_chromium.org, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement (FORMAT_ELAPSED, LENGTH_LONG) in time_format Use it in https://codereview.chromium.org/2751833005/ BUG=694451 Review-Url: https://codereview.chromium.org/2747253004 Cr-Commit-Position: refs/heads/master@{#457725} Committed: https://chromium.googlesource.com/chromium/src/+/c7e51754c49c1cb4f24dacbd694bc15d29ed0e2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -7 lines) Patch
M ui/base/l10n/formatter.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M ui/base/l10n/time_format.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/l10n/time_format_unittest.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 chunk +11 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Olivier
Hi I kept the pattern from other format that consist in abbreviating only minute and ...
3 years, 9 months ago (2017-03-15 17:58:17 UTC) #2
jungshik at Google
On 2017/03/15 17:58:17, Olivier Robin wrote: > Hi > > I kept the pattern from ...
3 years, 9 months ago (2017-03-16 18:15:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747253004/1
3 years, 9 months ago (2017-03-17 08:41:46 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 09:36:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c7e51754c49c1cb4f24dacbd694b...

Powered by Google App Engine
This is Rietveld 408576698