Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2747213002: Migrate WTF::Deque::last() to ::back() (Closed)

Created:
3 years, 9 months ago by pilgrim_google
Modified:
3 years, 9 months ago
CC:
ajuma+watch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, blink-reviews-wtf_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, groby+blinkspell_chromium.org, jbroman, Justin Novosad, kinuko+watch, Mikhail, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, timvolodine, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Deque::last() to ::back() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2747213002 Cr-Commit-Position: refs/heads/master@{#456989} Committed: https://chromium.googlesource.com/chromium/src/+/555dee3871c4fe9bdcbba6c1f226461772229b78

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Deque.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/DequeTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
pilgrim_google
3 years, 9 months ago (2017-03-14 17:38:57 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-14 18:10:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747213002/20001
3 years, 9 months ago (2017-03-15 02:28:10 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 04:22:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/555dee3871c4fe9bdcbba6c1f226...

Powered by Google App Engine
This is Rietveld 408576698