Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2747173006: INPUT element: stepDown() should not try to set an out-of-bound value. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT element: stepDown() should not try to set an out-of-bound value. In a case where we needed to clamp the value by the minimum value, we missed to clamp it by the maximum value. BUG=697318 Review-Url: https://codereview.chromium.org/2747173006 Cr-Commit-Position: refs/heads/master@{#456982} Committed: https://chromium.googlesource.com/chromium/src/+/44eec03e8559fb1c260c6ddc1cdeba73706fbd0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
keishi@, would you review this please?
3 years, 9 months ago (2017-03-15 03:09:10 UTC) #6
keishi
LGTM
3 years, 9 months ago (2017-03-15 03:34:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747173006/1
3 years, 9 months ago (2017-03-15 03:39:55 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 03:45:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/44eec03e8559fb1c260c6ddc1cde...

Powered by Google App Engine
This is Rietveld 408576698