Store dynamic Expect-CT state

Store dynamic Expect-CT state

This CL begins to implement the Expect-CT HTTP header (draft spec at
https://tools.ietf.org/html/draft-ietf-httpbis-expect-ct-00). It adds:

- a map to TransportSecurityState to track dynamically enabled Expect-CT
  hosts, mirroring how dynamic HPKP and HSTS state is stored.
- corresponding TransportSecurityState methods for adding, updating,
  and retrieving dynamic Expect-CT state.
- fields to the pre-existing TransportSecurityState::ExpectCTState struct
  needed to implement the spec (in particular, an |enforce| boolean and
  dates for implementing max-age). The ExpectCTState struct has up
  until now only been used for implementing Chrome's experimental
  preload-list-only version of Expect-CT, which is report-only and does
  not have an enforcement mode, nor a dynamic version.

(I2I at https://groups.google.com/a/chromium.org/d/msg/blink-dev/tgn5R-58iek/Q6YCnu0RFQAJ)

BUG=679012
Review-Url: https://codereview.chromium.org/2747173005
Cr-Commit-Position: refs/heads/master@{#465077}
Committed: https://chromium.googlesource.com/chromium/src/+/2cf091d5d77a9d4d5451a010c2fd90442b57345e

[estark, 2017-03-14 20:51:34]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 20:52:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-03-14 20:57:23]

Description was changed from

==========
Store dynamic Expect-CT state

This CL begins to implement the Expect-CT HTTP header (draft spec at
https://tools.ietf.org/html/draft-ietf-httpbis-expect-ct-00). It adds a map to
TransportSecurityState to track dynamically enabled Expect-CT hosts, mirroring
how dynamic HPKP and HSTS state is stored.

BUG=679012
==========

to

==========
Store dynamic Expect-CT state

This CL begins to implement the Expect-CT HTTP header (draft spec at
https://tools.ietf.org/html/draft-ietf-httpbis-expect-ct-00). It adds:

- a map to TransportSecurityState to track dynamically enabled Expect-CT
  hosts, mirroring how dynamic HPKP and HSTS state is stored.
- corresponding TransportSecurityState methods for adding, updating,
  and retrieving dynamic Expect-CT state.
- fields to the pre-existing TransportSecurityState::ExpectCTState struct
  needed to implement the spec (in particular, an |enforce| boolean and
  dates for implementing max-age). The ExpectCTState struct has up
  until now only been used for implementing Chrome's experimental
  preload-list-only version of Expect-CT, which is report-only and does
  not have an enforcement mode, nor a dynamic version.

BUG=679012
==========

[commit-bot: I haz the power, 2017-03-14 22:29:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 22:29:26]

Dry run: This issue passed the CQ dry run.

[estark, 2017-04-14 18:00:46]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 18:01:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-04-14 18:01:50]

Description was changed from

==========
Store dynamic Expect-CT state

This CL begins to implement the Expect-CT HTTP header (draft spec at
https://tools.ietf.org/html/draft-ietf-httpbis-expect-ct-00). It adds:

- a map to TransportSecurityState to track dynamically enabled Expect-CT
  hosts, mirroring how dynamic HPKP and HSTS state is stored.
- corresponding TransportSecurityState methods for adding, updating,
  and retrieving dynamic Expect-CT state.
- fields to the pre-existing TransportSecurityState::ExpectCTState struct
  needed to implement the spec (in particular, an |enforce| boolean and
  dates for implementing max-age). The ExpectCTState struct has up
  until now only been used for implementing Chrome's experimental
  preload-list-only version of Expect-CT, which is report-only and does
  not have an enforcement mode, nor a dynamic version.

BUG=679012
==========

to

==========
Store dynamic Expect-CT state

This CL begins to implement the Expect-CT HTTP header (draft spec at
https://tools.ietf.org/html/draft-ietf-httpbis-expect-ct-00). It adds:

- a map to TransportSecurityState to track dynamically enabled Expect-CT
  hosts, mirroring how dynamic HPKP and HSTS state is stored.
- corresponding TransportSecurityState methods for adding, updating,
  and retrieving dynamic Expect-CT state.
- fields to the pre-existing TransportSecurityState::ExpectCTState struct
  needed to implement the spec (in particular, an |enforce| boolean and
  dates for implementing max-age). The ExpectCTState struct has up
  until now only been used for implementing Chrome's experimental
  preload-list-only version of Expect-CT, which is report-only and does
  not have an enforcement mode, nor a dynamic version.

(I2I at
https://groups.google.com/a/chromium.org/d/msg/blink-dev/tgn5R-58iek/Q6YCnu0R...)

BUG=679012
==========

[estark, 2017-04-14 18:07:08]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 18:07:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-04-14 18:24:15]

estark@chromium.org changed reviewers:
+ mattm@chromium.org

[estark, 2017-04-14 18:24:15]

Hi mattm, would you be able to review a series of patches to implement the
Expect-CT header behind a flag? The implementation mostly mirrors the HSTS/HPKP
implementation. Thanks!

[commit-bot: I haz the power, 2017-04-14 19:30:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 19:30:16]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-04-15 04:50:18]

lgtm

https://codereview.chromium.org/2747173005/diff/40001/net/http/transport_secu...
File net/http/transport_security_state.cc (right):

https://codereview.chromium.org/2747173005/diff/40001/net/http/transport_secu...
net/http/transport_security_state.cc:1718:
end_(state.enabled_expect_ct_hosts_.end()) {}
Can you check state.CalledOnValidThread() here to ensure the iterator is created
on the correct thread?

[estark, 2017-04-15 19:16:09]

https://codereview.chromium.org/2747173005/diff/40001/net/http/transport_secu...
File net/http/transport_security_state.cc (right):

https://codereview.chromium.org/2747173005/diff/40001/net/http/transport_secu...
net/http/transport_security_state.cc:1718:
end_(state.enabled_expect_ct_hosts_.end()) {}
On 2017/04/15 04:50:17, mattm wrote:
> Can you check state.CalledOnValidThread() here to ensure the iterator is
created
> on the correct thread?

Done.

[estark, 2017-04-15 19:16:16]

The CQ bit was checked by estark@chromium.org

[estark, 2017-04-15 19:16:16]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2747173005/#ps60001
(title: "mattm comment")

[commit-bot: I haz the power, 2017-04-15 19:16:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-04-15 19:21:48]

The CQ bit was unchecked by estark@chromium.org

[estark, 2017-04-15 19:34:32]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-15 19:34:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-04-15 19:36:17]

I had forgotten to clear the dynamic Expect-CT state from various methods that
wipe dynamic data. I added that and will hold off on landing for a bit in case
you want to take another look next week.

[commit-bot: I haz the power, 2017-04-15 20:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 20:54:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mattm, 2017-04-17 22:28:18]

lgtm

[estark, 2017-04-17 22:29:36]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2017-04-17 22:30:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 00:30:12]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492468176846070,
"parent_rev": "c5e0038e479176c8e130882203ca4567f169b38b", "commit_rev":
"2cf091d5d77a9d4d5451a010c2fd90442b57345e"}

[commit-bot: I haz the power, 2017-04-18 00:31:09]

Description was changed from

==========
Store dynamic Expect-CT state

This CL begins to implement the Expect-CT HTTP header (draft spec at
https://tools.ietf.org/html/draft-ietf-httpbis-expect-ct-00). It adds:

- a map to TransportSecurityState to track dynamically enabled Expect-CT
  hosts, mirroring how dynamic HPKP and HSTS state is stored.
- corresponding TransportSecurityState methods for adding, updating,
  and retrieving dynamic Expect-CT state.
- fields to the pre-existing TransportSecurityState::ExpectCTState struct
  needed to implement the spec (in particular, an |enforce| boolean and
  dates for implementing max-age). The ExpectCTState struct has up
  until now only been used for implementing Chrome's experimental
  preload-list-only version of Expect-CT, which is report-only and does
  not have an enforcement mode, nor a dynamic version.

(I2I at
https://groups.google.com/a/chromium.org/d/msg/blink-dev/tgn5R-58iek/Q6YCnu0R...)

BUG=679012
==========

to

==========
Store dynamic Expect-CT state

This CL begins to implement the Expect-CT HTTP header (draft spec at
https://tools.ietf.org/html/draft-ietf-httpbis-expect-ct-00). It adds:

- a map to TransportSecurityState to track dynamically enabled Expect-CT
  hosts, mirroring how dynamic HPKP and HSTS state is stored.
- corresponding TransportSecurityState methods for adding, updating,
  and retrieving dynamic Expect-CT state.
- fields to the pre-existing TransportSecurityState::ExpectCTState struct
  needed to implement the spec (in particular, an |enforce| boolean and
  dates for implementing max-age). The ExpectCTState struct has up
  until now only been used for implementing Chrome's experimental
  preload-list-only version of Expect-CT, which is report-only and does
  not have an enforcement mode, nor a dynamic version.

(I2I at
https://groups.google.com/a/chromium.org/d/msg/blink-dev/tgn5R-58iek/Q6YCnu0R...)

BUG=679012

Review-Url: https://codereview.chromium.org/2747173005
Cr-Commit-Position: refs/heads/master@{#465077}
Committed:
https://chromium.googlesource.com/chromium/src/+/2cf091d5d77a9d4d5451a010c2fd...
==========

[commit-bot: I haz the power, 2017-04-18 00:31:12]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/2cf091d5d77a9d4d5451a010c2fd...