|
|
Revert of Add display::GetDisplayNearestView (patchset #17 id:790001 of https://codereview.chromium.org/2688413007/ )
Reason for revert:
This CL causes a compile failure on a Mac bot:
https://build.chromium.org/p/chromium/builders/Mac/builds/24801
[38396/49613] CXX obj/extensions/browser/browser_tests/system_display_apitest.o
FAILED: obj/extensions/browser/browser_tests/system_display_apitest.o
(snip)
../../extensions/browser/api/system_display/system_display_apitest.cc:58:37: error: non-virtual member function marked 'override' hides virtual member function
gfx::NativeView window) const override {
^
../../ui/display/screen.h:61:19: note: hidden overloaded virtual function 'display::Screen::GetDisplayNearestWindow' declared here: type mismatch at 1st parameter ('gfx::NativeWindow' (aka 'NSWindow *') vs 'gfx::NativeView' (aka 'NSView *'))
virtual Display GetDisplayNearestWindow(gfx::NativeWindow window) const = 0;
^
../../extensions/browser/api/system_display/system_display_apitest.cc:200:61: error: allocating an object of abstract class type 'extensions::MockScreen'
: provider_(new MockDisplayInfoProvider), screen_(new MockScreen) {}
^
../../ui/display/screen.h:61:19: note: unimplemented pure virtual method 'GetDisplayNearestWindow' in 'MockScreen'
virtual Display GetDisplayNearestWindow(gfx::NativeWindow window) const = 0;
^
2 errors generated.
Original issue's description:
> Add display::GetDisplayNearestView
>
> Add a method that gets the display with a given gfx::NativeView.
> The present API |display::GetDisplayNearestWindow| was also updated
> to accept gfx::NativeWindow to match its signature.
>
> BUG= 671401
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> TBR=benwells@chromium.org,sky@chromium.org,boliu@chromium.org,msw@chromium.org,halliwell@chromium.org,bshe@chromium.org,alexclarke@chromium.org
>
> Review-Url: https://codereview.chromium.org/2688413007
> Cr-Commit-Position: refs/heads/master@{#457016}
> Committed: https://chromium.googlesource.com/chromium/src/+/93bb5a29073d2cb41b20d3cc6cf59459a3906043
TBR=oshima@chromium.org,boliu@chromium.org,tapted@chromium.org,benwells@chromium.org,sky@chromium.org,msw@chromium.org,halliwell@chromium.org,bshe@chromium.org,alexclarke@chromium.org,jinsukkim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 671401
Review-Url: https://codereview.chromium.org/2747143005
Cr-Commit-Position: refs/heads/master@{#457025}
Committed: https://chromium.googlesource.com/chromium/src/+/a0c89e94b3310fa12b58db00eaca0e66c2f98c7b
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+58 lines, -114 lines) |
Patch |
 |
M |
chrome/browser/android/vr_shell/vr_shell.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/display/output_protection_delegate.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/site_per_process_interactive_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/chrome_views_delegate.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/profiles/user_manager_view.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/status_bubble_views.cc
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
|
View
|
|
3 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/toolbar/toolbar_button.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/validation_message_bubble_view.cc
|
View
|
|
2 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chromecast/graphics/cast_screen.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
components/constrained_window/constrained_window_views.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_base.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_widget_host_view_mac.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/web_contents/web_contents_view_android.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/web_contents/web_contents_view_mac.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
extensions/shell/browser/shell_screen.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
headless/lib/browser/headless_screen.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
headless/lib/browser/headless_screen.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/android/display_android_manager.h
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
ui/android/display_android_manager.cc
|
View
|
|
2 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
M |
ui/android/dummy_screen_android.cc
|
View
|
|
1 chunk |
+1 line, -5 lines |
0 comments
|
Download
|
 |
M |
ui/app_list/presenter/app_list_presenter_impl.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/aura/test/test_screen.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
ui/base/layout.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/display/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
ui/display/ios/screen_ios.mm
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ui/display/mac/screen_mac.mm
|
View
|
|
2 chunks |
+6 lines, -10 lines |
0 comments
|
Download
|
 |
M |
ui/display/screen.h
|
View
|
|
2 chunks |
+1 line, -8 lines |
0 comments
|
Download
|
 |
M |
ui/display/screen.cc
|
View
|
|
1 chunk |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
D |
ui/display/screen_android.cc
|
View
|
|
1 chunk |
+0 lines, -22 lines |
0 comments
|
Download
|
 |
M |
ui/display/screen_aura.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ui/display/screen_base.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/display/screen_base.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/display/test/test_screen.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/display/test/test_screen.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/display/win/screen_win.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/display/win/screen_win.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/message_center/views/toast_contents_view.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/views/controls/textfield/textfield.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ui/views/mus/screen_mus.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
ui/views/mus/screen_mus.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 6 (3 generated)
|