[DevTools] Separate old Application tab code

[DevTools] Separate old Application tab code

This CL moves "old" application tab code into a new class so the new
codebase could be built in parallel, allowing us to run experiment and
to port features gradually.

BUG=698027
Review-Url: https://codereview.chromium.org/2747123008
Cr-Commit-Position: refs/heads/master@{#458873}
Committed: https://chromium.googlesource.com/chromium/src/+/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5

[eostroukhov, 2017-03-17 00:09:35]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 00:10:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-03-17 00:15:17]

eostroukhov@chromium.org changed reviewers:
+ caseq@chromium.org, dgozman@chromium.org

[commit-bot: I haz the power, 2017-03-17 03:09:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 03:09:44]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-03-17 17:50:12]

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
(right):

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:2:
* Copyright (C) 2007, 2008, 2010 Apple Inc.  All rights reserved.
One of the files should have new copyright.

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:47:
sidebarElement.appendChild(this._sidebarTree.element);
Instead of passing sidebarElement, let's have this.element on
ApplicationPanelSidebar, which panel will put into the right place.

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:98:
splitWidget.setMainWidget(mainContainer);
Same for splitWidget.

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:127:
static _instance() {
Who needs this?

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:129:
self.runtime.sharedInstance(Resources.ApplicationPanelSidebar));
Note this requires a declaration in module.json.

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:191:
focus() {
Who is calling this method now? Should we make this a Widget?

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:43:
'_applicationCacheModel', '_domStorageView', '_resourcesSection',
'cacheStorageListTreeElement',
Let's do this manually, so that we can JSDoc it.

[eostroukhov, 2017-03-17 19:00:40]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[eostroukhov, 2017-03-17 19:01:12]

Thank you for the review. Please take another look.

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
(right):

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:2:
* Copyright (C) 2007, 2008, 2010 Apple Inc.  All rights reserved.
On 2017/03/17 17:50:11, dgozman wrote:
> One of the files should have new copyright.

ApplicationPanelSidebar retains the code so it will have the older notice.

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:47:
sidebarElement.appendChild(this._sidebarTree.element);
On 2017/03/17 17:50:11, dgozman wrote:
> Instead of passing sidebarElement, let's have this.element on
> ApplicationPanelSidebar, which panel will put into the right place.

Done.

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:98:
splitWidget.setMainWidget(mainContainer);
On 2017/03/17 17:50:11, dgozman wrote:
> Same for splitWidget.

Done.

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:127:
static _instance() {
On 2017/03/17 17:50:11, dgozman wrote:
> Who needs this?

Done.

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:129:
self.runtime.sharedInstance(Resources.ApplicationPanelSidebar));
On 2017/03/17 17:50:11, dgozman wrote:
> Note this requires a declaration in module.json.

Code was removed

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:191:
focus() {
On 2017/03/17 17:50:11, dgozman wrote:
> Who is calling this method now? Should we make this a Widget?

Panel will now directly set focus on a sidebar tree.

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2747123008/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:43:
'_applicationCacheModel', '_domStorageView', '_resourcesSection',
'cacheStorageListTreeElement',
On 2017/03/17 17:50:11, dgozman wrote:
> Let's do this manually, so that we can JSDoc it.

Done. I did not want to change visibility too much so I had to access private
properties via square brackets to make compiler happy.

[commit-bot: I haz the power, 2017-03-17 19:01:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 22:57:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 22:57:19]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[eostroukhov, 2017-03-18 01:28:42]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 01:29:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-03-18 01:30:29]

I tried to move all "generic" code (e.g. views showing, category tree items,
etc) to ResourcesPanel. ApplicationPanelSidebar still tracks specific view
instances as that behavior will be drastically different in a new version.

Please take another look.

[commit-bot: I haz the power, 2017-03-18 03:16:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 03:16:57]

Dry run: This issue passed the CQ dry run.

[caseq, 2017-03-20 18:04:26]

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
(right):

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:761:
this._target = null;
Can we rather explicitly keep the model that we need?

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:43:
return viewClassesToClose.some(type => view instanceof type);
Looks like a virtual method would be more appropriate way to implement this.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:118:
get _applicationCacheModel() {
We try to avoid getters, and having a private one does not seem to be necessary,
so let's just change the call sites.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:119:
return this._sidebar['_applicationCacheModel'];
Wait... You're just accessing someone else's private symbol this way? Does not
look good!

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:125:
get _domStorageView() {
ditto.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:132:
get _resourcesSection() {
ditto.

[dgozman, 2017-03-20 18:29:11]

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:106: //
TODO[eostroukhov]: Code below is used for tests. Test will be updated as the
sidebar
style: use parens with todo: TODO(eostroukhov)

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:107: //
gets reimplemented and this code will go away.
Maybe just change the tests right away to avoid ugly code below?

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:223:
Resources.StorageCategoryTreeElement = class extends
Resources.SidebarTreeElement {
Why do we have tree elements in this file? Shouldn't these be a part of
ApplicationPanelSidebar?

[eostroukhov, 2017-03-20 18:40:14]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[eostroukhov, 2017-03-20 18:40:54]

The CQ bit was unchecked by eostroukhov@chromium.org

[commit-bot: I haz the power, 2017-03-20 18:40:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-03-20 19:27:40]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 19:27:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-03-20 19:28:02]

Thanks for the review. Updated. Please take another look.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
(right):

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js:761:
this._target = null;
On 2017/03/20 18:04:26, caseq wrote:
> Can we rather explicitly keep the model that we need?

Done.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:43:
return viewClassesToClose.some(type => view instanceof type);
On 2017/03/20 18:04:26, caseq wrote:
> Looks like a virtual method would be more appropriate way to implement this.

Yes, I have considered it. I decided against it as this was meant a simple
refactoring change to extract some functionality - and this change would require
introducing an interface (Application pane views don't have a common
superclass/interface other then UI.Widget) and then touching individual view
classes. Currently, this is not directly required for this functionality.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:106: //
TODO[eostroukhov]: Code below is used for tests. Test will be updated as the
sidebar
On 2017/03/20 18:29:11, dgozman wrote:
> style: use parens with todo: TODO(eostroukhov)

TODO is gone now.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:107: //
gets reimplemented and this code will go away.
On 2017/03/20 18:29:11, dgozman wrote:
> Maybe just change the tests right away to avoid ugly code below?

Done.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:118:
get _applicationCacheModel() {
On 2017/03/20 18:04:26, caseq wrote:
> We try to avoid getters, and having a private one does not seem to be
necessary,
> so let's just change the call sites.

Done.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:119:
return this._sidebar['_applicationCacheModel'];
On 2017/03/20 18:04:26, caseq wrote:
> Wait... You're just accessing someone else's private symbol this way? Does not
> look good!

Done.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:125:
get _domStorageView() {
On 2017/03/20 18:04:26, caseq wrote:
> ditto.

Done.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:132:
get _resourcesSection() {
On 2017/03/20 18:04:26, caseq wrote:
> ditto.

Done.

https://codereview.chromium.org/2747123008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:223:
Resources.StorageCategoryTreeElement = class extends
Resources.SidebarTreeElement {
On 2017/03/20 18:29:11, dgozman wrote:
> Why do we have tree elements in this file? Shouldn't these be a part of
> ApplicationPanelSidebar?

This is the code that is shared between old and new sidebar. I'm not too eager
to introduce a new source file for it...

[commit-bot: I haz the power, 2017-03-20 21:04:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:04:24]

Dry run: This issue passed the CQ dry run.

[eostroukhov, 2017-03-21 23:16:55]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 23:17:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-03-21 23:19:19]

This CL was updated - I pushed some changes from the branches built on top of
it. Please take another look.

[commit-bot: I haz the power, 2017-03-21 23:28:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 23:28:20]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dgozman, 2017-03-22 00:07:27]

https://codereview.chromium.org/2747123008/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2747123008/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:66:
return this._resourcesLastSelectedItemSetting.get();
This setting has a default value of {}, which is inconsistent with return type.

https://codereview.chromium.org/2747123008/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:98:
showApplicationCache(frameId) {
Why do we need this?

https://codereview.chromium.org/2747123008/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:116:
showDatabase(database, tableName) {
And this?

https://codereview.chromium.org/2747123008/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:140:
showResource(resource, line, column) {
And this.

[eostroukhov, 2017-03-22 00:52:26]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 00:53:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-03-22 00:54:09]

Thank you for your comments, I addressed them. Please take another look.

https://codereview.chromium.org/2747123008/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2747123008/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:66:
return this._resourcesLastSelectedItemSetting.get();
On 2017/03/22 00:07:27, dgozman wrote:
> This setting has a default value of {}, which is inconsistent with return
type.

I replaced with an empty string

https://codereview.chromium.org/2747123008/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:98:
showApplicationCache(frameId) {
On 2017/03/22 00:07:27, dgozman wrote:
> Why do we need this?

I removed it for now.

https://codereview.chromium.org/2747123008/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:116:
showDatabase(database, tableName) {
On 2017/03/22 00:07:27, dgozman wrote:
> And this?

Removed

https://codereview.chromium.org/2747123008/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:140:
showResource(resource, line, column) {
On 2017/03/22 00:07:27, dgozman wrote:
> And this.

Removed

[commit-bot: I haz the power, 2017-03-22 02:54:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 02:54:57]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[caseq, 2017-03-22 18:10:19]

https://codereview.chromium.org/2747123008/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2747123008/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:10:
this._resourcesLastSelectedItemSetting =
Common.settings.createSetting('resourcesLastSelectedItem', '');
Doesn't this logically belong to the sidebar?

https://codereview.chromium.org/2747123008/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:65:
lastSelectedItemURL() {
ditto.

https://codereview.chromium.org/2747123008/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:175:
Resources.BaseStorageTreeElement = class extends UI.TreeElement {
Is it used by the panel at all? Looks like it should go to ApplicationSidebar as
well...

[eostroukhov, 2017-03-22 18:15:03]

https://codereview.chromium.org/2747123008/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2747123008/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:10:
this._resourcesLastSelectedItemSetting =
Common.settings.createSetting('resourcesLastSelectedItem', '');
On 2017/03/22 18:10:18, caseq wrote:
> Doesn't this logically belong to the sidebar?

There will be two sidebars - old and the new one (with the frames selector). I
am not sure where to put code that is shared between them. Views are in this
file so I decided I might as well keep the basic tree items stuff...

[eostroukhov, 2017-03-22 19:04:55]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 19:05:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2017-03-22 19:08:30]

Uploaded a new version, please take another look.

https://codereview.chromium.org/2747123008/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
(right):

https://codereview.chromium.org/2747123008/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:10:
this._resourcesLastSelectedItemSetting =
Common.settings.createSetting('resourcesLastSelectedItem', '');
On 2017/03/22 18:10:18, caseq wrote:
> Doesn't this logically belong to the sidebar?

For now, I would like to keep it in the panel. I tried several approaches and
the changes become more extensive that I would like at this point.

https://codereview.chromium.org/2747123008/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:175:
Resources.BaseStorageTreeElement = class extends UI.TreeElement {
On 2017/03/22 18:10:18, caseq wrote:
> Is it used by the panel at all? Looks like it should go to ApplicationSidebar
as
> well...

I moved it to the sidebar.

[dgozman, 2017-03-22 19:20:29]

lgtm

[eostroukhov, 2017-03-22 19:28:06]

The CQ bit was unchecked by eostroukhov@chromium.org

[eostroukhov, 2017-03-22 19:28:10]

The CQ bit was checked by eostroukhov@chromium.org

[commit-bot: I haz the power, 2017-03-22 19:29:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 21:00:17]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1490210890802290,
"parent_rev": "da4bc538cc6b36cf5246f3dfcca30562a43d4947", "commit_rev":
"8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5"}

[commit-bot: I haz the power, 2017-03-22 21:01:03]

Description was changed from

==========
[DevTools] Separate old Application tab code

This CL moves "old" application tab code into a new class so the new
codebase could be built in parallel, allowing us to run experiment and
to port features gradually.

BUG=698027
==========

to

==========
[DevTools] Separate old Application tab code

This CL moves "old" application tab code into a new class so the new
codebase could be built in parallel, allowing us to run experiment and
to port features gradually.

BUG=698027

Review-Url: https://codereview.chromium.org/2747123008
Cr-Commit-Position: refs/heads/master@{#458873}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f7c3a1ade6b01cb90a8648d1e4d...
==========

[commit-bot: I haz the power, 2017-03-22 21:01:05]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/8f7c3a1ade6b01cb90a8648d1e4d...