Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2747123004: Out-of-process file patcher: DCHECK the files in the utility process (Closed)

Created:
3 years, 9 months ago by Noel Gordon
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Out-of-process file patcher: DCHECK the files in the utility process In chrome_content_utility_client.cc, the files received for patching are never invalid. DCHECK that, as we have done in subsequent patches mojo'n the utility process when the mojo API includes a base::File. No change in behavior, no new tests. BUG=597124 Review-Url: https://codereview.chromium.org/2747123004 Cr-Commit-Position: refs/heads/master@{#457260} Committed: https://chromium.googlesource.com/chromium/src/+/66e59dfbe693f78e9aa030af3ae8cfe835246cbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/utility/chrome_content_utility_client.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Noel Gordon
PTAL
3 years, 9 months ago (2017-03-15 04:15:28 UTC) #4
Sam McNally
lgtm
3 years, 9 months ago (2017-03-15 04:18:26 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-15 15:51:19 UTC) #9
waffles
lgtm
3 years, 9 months ago (2017-03-15 17:08:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747123004/1
3 years, 9 months ago (2017-03-15 23:19:06 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 23:26:26 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66e59dfbe693f78e9aa030af3ae8...

Powered by Google App Engine
This is Rietveld 408576698