Add --commit option and some polish to update_node.py.

Add --commit option and some polish to update_node.py.

NOTRY=true
R=machenbach@chromium.org
BUG=v8:6091
Review-Url: https://codereview.chromium.org/2747123002
Cr-Commit-Position: refs/heads/master@{#43781}
Committed: https://chromium.googlesource.com/v8/v8/+/4c9ba862941054284f5390016d0d507b3dcf98a0

[Michael Achenbach, 2017-03-14 10:50:42]

lgtm with nits and future remarks

https://codereview.chromium.org/2747123002/diff/1/tools/release/test_update_n...
File tools/release/test_update_node.py (right):

https://codereview.chromium.org/2747123002/diff/1/tools/release/test_update_n...
tools/release/test_update_node.py:99: process = subprocess.Popen(['git', 'diff',
'master', '--summary'],
Maybe just use subprocess.check_output for such simple calls.

https://codereview.chromium.org/2747123002/diff/1/tools/release/update_node.py
File tools/release/update_node.py (right):

https://codereview.chromium.org/2747123002/diff/1/tools/release/update_node.p...
tools/release/update_node.py:96: if error is not None:
I think error might be unused because you don't pipe to stderr as well. But I'd
maybe just check process.returncode as in
https://cs.chromium.org/chromium/src/v8/tools/sanitizers/sancov_formatter.py?...

https://codereview.chromium.org/2747123002/diff/1/tools/release/update_node.p...
tools/release/update_node.py:101: ["git", "checkout", "-b", "update_v8_to_%s" %
githash[0:8]],  # new branch
In order to run this automatically, we might need to add some more robustness,
e.g.:
- Clean up potentially bad old runs, cleanly checkout master
- Delete the work branch if it exists
- In case we push, delete work branch in the end
- For a bot, I'd use the same branch name to avoid things starting to spill (I
remember our old auto-roller version had a few hundred local branches at some
point)

https://codereview.chromium.org/2747123002/diff/1/tools/release/update_node.p...
tools/release/update_node.py:103: ["git", "commit", "-m", "Update V8 to %s" %
githash]          # new commit
Maybe in the message, the small git hash is enough too? How about a range (not
sure how we could easily know what revision it was before)?

https://codereview.chromium.org/2747123002/diff/1/tools/release/update_node.p...
tools/release/update_node.py:114: parser.add_argument("--commit", dest="commit",
nit: dest is redundant here, also above.

[Yang, 2017-03-14 12:42:19]

https://codereview.chromium.org/2747123002/diff/1/tools/release/test_update_n...
File tools/release/test_update_node.py (right):

https://codereview.chromium.org/2747123002/diff/1/tools/release/test_update_n...
tools/release/test_update_node.py:99: process = subprocess.Popen(['git', 'diff',
'master', '--summary'],
On 2017/03/14 10:50:42, Michael Achenbach wrote:
> Maybe just use subprocess.check_output for such simple calls.

Done.

https://codereview.chromium.org/2747123002/diff/1/tools/release/update_node.py
File tools/release/update_node.py (right):

https://codereview.chromium.org/2747123002/diff/1/tools/release/update_node.p...
tools/release/update_node.py:96: if error is not None:
On 2017/03/14 10:50:42, Michael Achenbach wrote:
> I think error might be unused because you don't pipe to stderr as well. But
I'd
> maybe just check process.returncode as in
>
https://cs.chromium.org/chromium/src/v8/tools/sanitizers/sancov_formatter.py?...

Changed to check_output

https://codereview.chromium.org/2747123002/diff/1/tools/release/update_node.p...
tools/release/update_node.py:101: ["git", "checkout", "-b", "update_v8_to_%s" %
githash[0:8]],  # new branch
On 2017/03/14 10:50:42, Michael Achenbach wrote:
> In order to run this automatically, we might need to add some more robustness,
> e.g.:
> - Clean up potentially bad old runs, cleanly checkout master
> - Delete the work branch if it exists
> - In case we push, delete work branch in the end
> - For a bot, I'd use the same branch name to avoid things starting to spill (I
> remember our old auto-roller version had a few hundred local branches at some
> point)

Added these points to the issue.

https://codereview.chromium.org/2747123002/diff/1/tools/release/update_node.p...
tools/release/update_node.py:103: ["git", "commit", "-m", "Update V8 to %s" %
githash]          # new commit
On 2017/03/14 10:50:42, Michael Achenbach wrote:
> Maybe in the message, the small git hash is enough too? How about a range (not
> sure how we could easily know what revision it was before)?

Done.

https://codereview.chromium.org/2747123002/diff/1/tools/release/update_node.p...
tools/release/update_node.py:114: parser.add_argument("--commit", dest="commit",
On 2017/03/14 10:50:42, Michael Achenbach wrote:
> nit: dest is redundant here, also above.

Done.

[Yang, 2017-03-14 12:45:42]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-03-14 12:45:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2747123002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-03-14 12:45:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 12:49:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489495542036670,
"parent_rev": "f2bab459677a1b2fd0e31a17d86684c6b45602ac", "commit_rev":
"4c9ba862941054284f5390016d0d507b3dcf98a0"}

[commit-bot: I haz the power, 2017-03-14 12:49:31]

Description was changed from

==========
Add --commit option and some polish to update_node.py.

NOTRY=true
R=machenbach@chromium.org
BUG=v8:6091
==========

to

==========
Add --commit option and some polish to update_node.py.

NOTRY=true
R=machenbach@chromium.org
BUG=v8:6091

Review-Url: https://codereview.chromium.org/2747123002
Cr-Commit-Position: refs/heads/master@{#43781}
Committed:
https://chromium.googlesource.com/v8/v8/+/4c9ba862941054284f5390016d0d507b3dc...
==========

[commit-bot: I haz the power, 2017-03-14 12:49:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4c9ba862941054284f5390016d0d507b3dc...