Let Range::expand not crash when Range's start node is not connected to document.

Let Range::expand not crash when Range's start node is not connected 
 to document.

In the condition, Range::expand calls create VisiblePosition and
 DCHECK(node.isConnected()) failed.
This CL lets Range::expand not do nothing in the condition.

BUG=698123
Review-Url: https://codereview.chromium.org/2747113003
Cr-Commit-Position: refs/heads/master@{#457340}
Committed: https://chromium.googlesource.com/chromium/src/+/67a26dc6928cf5dac2f2f2242f24ddb5b60e216b

[yoichio, 2017-03-15 09:32:33]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 09:32:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 12:47:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 12:47:01]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-03-16 01:44:04]

Description was changed from

==========
Range::expand not crash

BUG=
==========

to

==========
Let Range::expand not crash when Range's start node is not connected.

In the condition, Range::expand calls create VisiblePosition and
 DCHECK(node.isConnected()) failed.
This CL lets Range::expand not do nothing in the condition.

BUG=698123
==========

[yoichio, 2017-03-16 01:44:04]

yoichio@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[yoichio, 2017-03-16 01:44:27]

Description was changed from

==========
Let Range::expand not crash when Range's start node is not connected.

In the condition, Range::expand calls create VisiblePosition and
 DCHECK(node.isConnected()) failed.
This CL lets Range::expand not do nothing in the condition.

BUG=698123
==========

to

==========
Let Range::expand not crash when Range's start node is not connected 
 to document.

In the condition, Range::expand calls create VisiblePosition and
 DCHECK(node.isConnected()) failed.
This CL lets Range::expand not do nothing in the condition.

BUG=698123
==========

[tkent, 2017-03-16 01:47:15]

Can you remove Range::expand() instead of fixing it?
crbug.com/445218

[yoichio, 2017-03-16 01:58:09]

On 2017/03/16 01:47:15, tkent wrote:
> Can you remove Range::expand() instead of fixing it?
> crbug.com/445218

There is compat issue as Philip says:
"the deprecation message suggests using another non-standard API"

Anyway we should remove this now?

[yosin_UTC9, 2017-03-16 02:14:53]

On 2017/03/16 at 01:58:09, yoichio wrote:
> On 2017/03/16 01:47:15, tkent wrote:
> > Can you remove Range::expand() instead of fixing it?
> > crbug.com/445218
> 
> There is compat issue as Philip says:
> "the deprecation message suggests using another non-standard API"
> 
> Anyway we should remove this now?

+1 for removal. Range.cpp should not include editing/*
Once we remove Range::expand(), we can get rid of VisiblePosition.cpp and
VisibleUnits.cpp

[tkent, 2017-03-16 02:19:49]

On 2017/03/16 at 01:58:09, yoichio wrote:
> On 2017/03/16 01:47:15, tkent wrote:
> > Can you remove Range::expand() instead of fixing it?
> > crbug.com/445218
> 
> There is compat issue as Philip says:
> "the deprecation message suggests using another non-standard API"
> 
> Anyway we should remove this now?

We already agreed standardizing Selection.modify(), right?  If so, I think
removing Range.expand() now is acceptable.

Of course, adding modify() to Selection API first is much better, and it would
take some time.  So, landing this CL now is also reasonable.

[tkent, 2017-03-16 03:14:00]

lgtm

[yoichio, 2017-03-16 03:40:45]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-03-16 03:41:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 03:45:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489635645965130, "parent_rev":
"3e651a1204f7bc387b1c077699e3a95348e1f525", "commit_rev":
"67a26dc6928cf5dac2f2f2242f24ddb5b60e216b"}

[commit-bot: I haz the power, 2017-03-16 03:46:10]

Description was changed from

==========
Let Range::expand not crash when Range's start node is not connected 
 to document.

In the condition, Range::expand calls create VisiblePosition and
 DCHECK(node.isConnected()) failed.
This CL lets Range::expand not do nothing in the condition.

BUG=698123
==========

to

==========
Let Range::expand not crash when Range's start node is not connected 
 to document.

In the condition, Range::expand calls create VisiblePosition and
 DCHECK(node.isConnected()) failed.
This CL lets Range::expand not do nothing in the condition.

BUG=698123

Review-Url: https://codereview.chromium.org/2747113003
Cr-Commit-Position: refs/heads/master@{#457340}
Committed:
https://chromium.googlesource.com/chromium/src/+/67a26dc6928cf5dac2f2f2242f24...
==========

[commit-bot: I haz the power, 2017-03-16 03:46:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67a26dc6928cf5dac2f2f2242f24...