Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2747083002: In make_hfs.sh, use `diskutil unmount force` instead of just unmount. (Closed)

Created:
3 years, 9 months ago by Robert Sesek
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In make_hfs.sh, use `diskutil unmount force` instead of just unmount. BUG=696529 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2747083002 Cr-Commit-Position: refs/heads/master@{#456680} Committed: https://chromium.googlesource.com/chromium/src/+/fb87dbf4e2eae4532668bebc585b3017970ef3b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/data/safe_browsing/dmg/make_hfs.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Robert Sesek
3 years, 9 months ago (2017-03-14 02:46:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747083002/1
3 years, 9 months ago (2017-03-14 12:53:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fb87dbf4e2eae4532668bebc585b3017970ef3b9
3 years, 9 months ago (2017-03-14 12:59:06 UTC) #11
Dirk Pranke
3 years, 9 months ago (2017-03-14 17:24:53 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698