Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2747053002: PVer4: Filter out the safe crxs before calling OnCheckExtensionsResult (Closed)

Created:
3 years, 9 months ago by Jialiu Lin
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

PVer4: Filter out the safe crxs before calling OnCheckExtensionsResult The argument for OnCheckExtensionsResult should only contain the bad extensions, but PVer4 code was including all CRXs (blacklisted or not). BUG=700145 Review-Url: https://codereview.chromium.org/2742913002 Cr-Commit-Position: refs/heads/master@{#456212} (cherry picked from commit ec975c1d7990d87c1be9c03e0d94e38e20a7389b) Review-Url: https://codereview.chromium.org/2747053002 . Cr-Commit-Position: refs/branch-heads/3029@{#164} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/ad44e53304cef79c5ca790aab3fe7a23e674be7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -38 lines) Patch
M components/safe_browsing_db/v4_local_database_manager.h View 3 chunks +17 lines, -9 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 5 chunks +37 lines, -20 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager_unittest.cc View 3 chunks +96 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Jialiu Lin
3 years, 9 months ago (2017-03-13 21:21:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ad44e53304cef79c5ca790aab3fe7a23e674be7a.

Powered by Google App Engine
This is Rietveld 408576698