Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2746973005: Reenable WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames (Closed)

Created:
3 years, 9 months ago by emircan
Modified:
3 years, 9 months ago
Reviewers:
mcasas
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable WebRtcCaptureFromElementBrowserTest.VerifyCanvasCaptureOffscreenCanvasCommitFrames - Reenable the test to see if the changes on the failed check[0] help. - Avoid apppending <canvas> to DOM to isolate compositing errors and logs, see the bug for an example. [0] https://codereview.chromium.org/2731743002 BUG=695452 Review-Url: https://codereview.chromium.org/2746973005 Cr-Commit-Position: refs/heads/master@{#456643} Committed: https://chromium.googlesource.com/chromium/src/+/84f8545ccd1ac362720093ebc27191d1cdd4fbf3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M content/browser/webrtc/webrtc_capture_from_element_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/test/data/media/canvas_capture.html View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
emircan
PTAL.
3 years, 9 months ago (2017-03-13 22:45:17 UTC) #5
mcasas
lgtm
3 years, 9 months ago (2017-03-14 00:27:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746973005/1
3 years, 9 months ago (2017-03-14 06:57:17 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 07:02:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84f8545ccd1ac362720093ebc271...

Powered by Google App Engine
This is Rietveld 408576698