Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2746973004: Remove the expectation for fast/canvas/canvas-large-pattern.html (Closed)

Created:
3 years, 9 months ago by Stephen Chennney
Modified:
3 years, 9 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the expectation for fast/canvas/canvas-large-pattern.html When the test was converted to testharness.js, we lost the expectations file that recorded the failing result, so now the test fails on the bots and needs a TestExpectations line. But this is not a transient expectation, so update the test to record the expected failure and make sure there's a bug for the underlying problem (which we might choose to WontFix). TBR=junov@chromium.org BUG=696724 Review-Url: https://codereview.chromium.org/2746973004 Cr-Commit-Position: refs/heads/master@{#456477} Committed: https://chromium.googlesource.com/chromium/src/+/142d306b53b0ad88777c23dc9ecebd79487c063f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-large-pattern.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746973004/1
3 years, 9 months ago (2017-03-13 19:13:13 UTC) #2
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 20:58:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/142d306b53b0ad88777c23dc9ece...

Powered by Google App Engine
This is Rietveld 408576698