Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2746933002: Refactor <paint> URL resolution in SVGResources (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor <paint> URL resolution in SVGResources Hoist the has-url check out of paintingResourceFromSVGPaint(), and remove |hasPendingResource| - consider all null-returns as having pending resources. (This means "incorrect" <paint> URL references are considered pending, just as URL references for other resource types.) BUG=454767 Review-Url: https://codereview.chromium.org/2746933002 Cr-Commit-Position: refs/heads/master@{#456374} Committed: https://chromium.googlesource.com/chromium/src/+/ec5133da581afeb7e71904f528df9ae4966ccfaf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -25 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGResources.cpp View 2 chunks +10 lines, -25 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 9 months ago (2017-03-13 13:25:10 UTC) #5
Stephen Chennney
lgtm
3 years, 9 months ago (2017-03-13 14:24:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746933002/1
3 years, 9 months ago (2017-03-13 14:24:31 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 14:29:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec5133da581afeb7e71904f528df...

Powered by Google App Engine
This is Rietveld 408576698