Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2746923003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (gcm, instance_id, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=fgorski@chromium.org, jianli@chromium.org Review-Url: https://codereview.chromium.org/2746923003 Cr-Commit-Position: refs/heads/master@{#456907} Committed: https://chromium.googlesource.com/chromium/src/+/490443a5bc33e2a38a08c25adb39022567a1cce3

Patch Set 1 : Add TEAM/COMPONENT #

Total comments: 2

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/extensions/api/gcm/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/instance_id/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download
M components/offline_items_collection/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-13 17:19:32 UTC) #2
fgorski
lgtm on: chrome/browser/extensions/api/gcm/OWNERS chrome/browser/extensions/api/instance_id/OWNERS Please hold off with the patch for David to look at ...
3 years, 9 months ago (2017-03-13 18:35:22 UTC) #4
David Trainor- moved to gerrit
lgtm https://codereview.chromium.org/2746923003/diff/20001/components/offline_items_collection/OWNERS File components/offline_items_collection/OWNERS (right): https://codereview.chromium.org/2746923003/diff/20001/components/offline_items_collection/OWNERS#newcode6 components/offline_items_collection/OWNERS:6: # COMPONENT: UI>Browser>Offline Let's make this UI>Browser>Downloads for ...
3 years, 9 months ago (2017-03-14 15:16:55 UTC) #5
ymzhang1
Thanks for the comments! https://codereview.chromium.org/2746923003/diff/20001/components/offline_items_collection/OWNERS File components/offline_items_collection/OWNERS (right): https://codereview.chromium.org/2746923003/diff/20001/components/offline_items_collection/OWNERS#newcode6 components/offline_items_collection/OWNERS:6: # COMPONENT: UI>Browser>Offline On 2017/03/14 ...
3 years, 9 months ago (2017-03-14 23:48:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746923003/40001
3 years, 9 months ago (2017-03-14 23:49:50 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 00:15:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/490443a5bc33e2a38a08c25adb39...

Powered by Google App Engine
This is Rietveld 408576698