Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2746923002: Implement nested switches and missing switch continue targets. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement nested switches and missing switch continue targets. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/4f6d58fc50222fdf1fcb610fdc3ea64b31fe7285

Patch Set 1 #

Patch Set 2 : Update uses of verifier. #

Patch Set 3 : Long line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -59 lines) Patch
M pkg/front_end/lib/src/fasta/builder/scope.dart View 2 chunks +19 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/compile_platform.dart View 1 2 chunks +2 lines, -19 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta.dart View 2 chunks +2 lines, -18 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 8 chunks +35 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 4 chunks +12 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/verifier.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/kernel_chain.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/kernel/lib/verifier.dart View 1 2 2 chunks +18 lines, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-03-13 11:56:59 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-13 12:05:27 UTC) #3
ahe
3 years, 9 months ago (2017-03-13 12:52:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4f6d58fc50222fdf1fcb610fdc3ea64b31fe7285 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698