Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

Issue 2746923002: Implement nested switches and missing switch continue targets. (Closed)
Patch Set: Long line. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
index 051ce077646c6a944d16785adbd995b0309ee915..5f2e87e875dba6597fcadb21bcf3e542f646cc64 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
@@ -88,6 +88,8 @@ import 'kernel_builder.dart'
TypeBuilder,
TypeVariableBuilder;
+import 'verifier.dart' show verifyProgram;
+
class KernelTarget extends TargetImplementation {
final DillTarget dillTarget;
@@ -214,7 +216,8 @@ class KernelTarget extends TargetImplementation {
: writeLinkedProgram(uri, program, isFullProgram: isFullProgram);
}
- Future<Program> writeProgram(Uri uri) async {
+ Future<Program> writeProgram(Uri uri,
+ {bool dumpIr: false, bool verify: false}) async {
if (loader.first == null) return null;
if (errors.isNotEmpty) {
return handleInputError(uri, null, isFullProgram: true);
@@ -229,6 +232,8 @@ class KernelTarget extends TargetImplementation {
// TODO(ahe): Don't call this from two different places.
setup_builtin_library.transformProgram(program);
otherTransformations();
+ if (dumpIr) this.dumpIr();
+ if (verify) this.verify();
errors.addAll(loader.collectCompileTimeErrors().map((e) => e.format()));
if (errors.isNotEmpty) {
return handleInputError(uri, null, isFullProgram: true);
@@ -623,6 +628,12 @@ class KernelTarget extends TargetImplementation {
printer.writeLibraryFile(library);
}
print("$sb");
+ ticker.logMs("Dumped IR");
+ }
+
+ void verify() {
+ errors.addAll(verifyProgram(program));
+ ticker.logMs("Verified program");
}
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/body_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/verifier.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698