Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2746893002:
Disable HistoryEntryInserterTest.AddSection unit test (Closed)
|
Created:
3 years, 9 months ago by gambard Modified:
3 years, 9 months ago CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable HistoryEntryInserterTest.AddSection unit test
Failing consistently
BUG=700814
TBR=lpromero@chromium.org
Review-Url: https://codereview.chromium.org/2746893002
Cr-Commit-Position: refs/heads/master@{#456344}
Committed: https://chromium.googlesource.com/chromium/src/+/e46508c00a4e04d5456dcecafbf7d2f38123040a
Patch Set 1 #
Total comments: 2
Patch Set 2 : Disable it #Messages
Total messages: 18 (12 generated)
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
gambard@chromium.org changed reviewers: + noyau@chromium.org
PTAL.
https://codereview.chromium.org/2746893002/diff/1/ios/chrome/browser/ui/histo... File ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm (right): https://codereview.chromium.org/2746893002/diff/1/ios/chrome/browser/ui/histo... ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm:99: return; To turn it off you should just have to rename the test DISABLED_AddSections
Thanks https://codereview.chromium.org/2746893002/diff/1/ios/chrome/browser/ui/histo... File ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm (right): https://codereview.chromium.org/2746893002/diff/1/ios/chrome/browser/ui/histo... ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm:99: return; On 2017/03/13 09:23:17, noyau wrote: > To turn it off you should just have to rename the test DISABLED_AddSections Ooops! Done
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Disable HistoryEntryInserterTest.AddSection unit test Failing consistently BUG=700814 ========== to ========== Disable HistoryEntryInserterTest.AddSection unit test Failing consistently BUG=700814 TBR=lpromero@chromium.org ==========
The CQ bit was checked by gambard@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489397943047880,
"parent_rev": "e5a8f430055ca5b8604f5c852306fe686b6e8732", "commit_rev":
"e46508c00a4e04d5456dcecafbf7d2f38123040a"}
lpromero@chromium.org changed reviewers: + lpromero@chromium.org
lgtm
Message was sent while issue was closed.
Description was changed from ========== Disable HistoryEntryInserterTest.AddSection unit test Failing consistently BUG=700814 TBR=lpromero@chromium.org ========== to ========== Disable HistoryEntryInserterTest.AddSection unit test Failing consistently BUG=700814 TBR=lpromero@chromium.org Review-Url: https://codereview.chromium.org/2746893002 Cr-Commit-Position: refs/heads/master@{#456344} Committed: https://chromium.googlesource.com/chromium/src/+/e46508c00a4e04d5456dcecafbf7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e46508c00a4e04d5456dcecafbf7... |
