Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2746843002: Enable CED HTML5 mode (Closed)

Created:
3 years, 9 months ago by Jinsuk Kim
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch, jshin+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable CED HTML5 mode Set CED(Compact Encoding Detector) to HTML5 mode in which the detector always returns WHATWG-compliant text encoding as output. Call sites now don't have to do post-detection conversion, which is removed in this CL together. BUG=698605 Review-Url: https://codereview.chromium.org/2746843002 Cr-Commit-Position: refs/heads/master@{#456610} Committed: https://chromium.googlesource.com/chromium/src/+/dd643ddc92e12037e88c4d9e004a868e90c3e5ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -58 lines) Patch
M base/i18n/encoding_detection.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextEncodingDetector.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/ced/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Jinsuk Kim
3 years, 9 months ago (2017-03-13 07:32:41 UTC) #6
Jinsuk Kim
https://cs.chromium.org/chromium/src/third_party/ced/src/compact_enc_det/compact_enc_det.cc?l=5649 is where the code was moved in ced.
3 years, 9 months ago (2017-03-13 07:34:01 UTC) #7
tkent
third_party/WebKit/Source/platform/text/TextEncodingDetector.cpp lgtm
3 years, 9 months ago (2017-03-13 07:38:03 UTC) #8
jungshik at Google
LGTM
3 years, 9 months ago (2017-03-13 23:58:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746843002/1
3 years, 9 months ago (2017-03-14 00:28:35 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 03:20:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dd643ddc92e12037e88c4d9e004a...

Powered by Google App Engine
This is Rietveld 408576698