Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2746823003: Revert of Use Opportunity Iterator to position text fragments in NGLineBuilder (Closed)

Created:
3 years, 9 months ago by yoichio
Modified:
3 years, 9 months ago
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use Opportunity Iterator to position text fragments in NGLineBuilder (patchset #4 id:80001 of https://codereview.chromium.org/2739683006/ ) Reason for revert: Test failures on bot: NGTextLayoutAlgorithmTest.TextFloatsAroundFloatsBefore https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/62088 Original issue's description: > Use Opportunity Iterator to position text fragments in NGLineBuilder > > This patch introduces NGLayoutOpportunityIterator to NGLineBuilder so it > can use it to search the next available opportunity to position text > fragments. > > With this patch NGLayout starts supporting a base text floating around > floats that are positioned before an inline fragment. > Example: > <div id="container"> > <div id="left-float1"></div> > <div id="left-float2"></div> > <div id="right-float"></div> > The quick brown fox jumps over the lazy dog > </div> > > BUG=635619 > TEST=NGTextLayoutAlgorithmTest::TextFloatsAroundFloatsBefore > > Review-Url: https://codereview.chromium.org/2739683006 > Cr-Commit-Position: refs/heads/master@{#456278} > Committed: https://chromium.googlesource.com/chromium/src/+/207688fb45319568db61e59c4c8391517793bf47 TBR=kojii@chromium.org,ikilpatrick@chromium.org,glebl@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -243 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_base_layout_algorithm_test.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_base_layout_algorithm_test.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 4 chunks +31 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 3 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_line_builder.h View 4 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc View 10 chunks +7 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm_test.cc View 1 chunk +0 lines, -101 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
yoichio
Created Revert of Use Opportunity Iterator to position text fragments in NGLineBuilder
3 years, 9 months ago (2017-03-13 08:09:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746823003/1
3 years, 9 months ago (2017-03-13 08:09:24 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 08:11:33 UTC) #5
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

Powered by Google App Engine
This is Rietveld 408576698