third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.cc - Issue 2746823003: Revert of Use Opportunity Iterator to position text fragments in NGLineBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.cc

Issue 2746823003: Revert of Use Opportunity Iterator to position text fragments in NGLineBuilder (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.h ('k') | third_party/WebKit/Source/core/layout/ng/ng_base_layout_algorithm_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.cc b/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.cc

index c00d7d7b09de4689b8ed4a0b41cad55b68698f04..5c7edf0b0ee5773766e7ec303d8da5aeeb9fe472 100644

--- a/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.cc

+++ b/third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_offset.cc

@@ -56,10 +56,6 @@

std::tie(inline_offset, block_offset);

}

-bool NGLogicalOffset::operator!=(const NGLogicalOffset& other) const {

- return !operator==(other);

NGLogicalOffset NGLogicalOffset::operator+(const NGLogicalOffset& other) const {

NGLogicalOffset result;

result.inline_offset = this->inline_offset + other.inline_offset;