third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp - Issue 2746783002: [ServiceWorker] Mojofy InstallEvent of Service Worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp

Issue 2746783002: [ServiceWorker] Mojofy InstallEvent of Service Worker (Closed)

Patch Set: Fix the test failure Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp

diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp b/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp

index ad014e5dabb74ba6de5f02fd616bf7ef0171687e..a8ad7929923c4e95a9437acf2bac59aa77de98c8 100644

--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp

+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp

@@ -71,6 +71,7 @@ class MockServiceWorkerContextClient : public WebServiceWorkerContextClient {

NOTREACHED();

}

void RegisterForeignFetchScopes(

+ int event_id,

horo 2017/04/27 09:22:21 nit: install_event_id

xiaofengzhang 2017/04/28 07:14:24 Done.

const WebVector<WebURL>& sub_scopes,

const WebVector<WebSecurityOrigin>& origins) override {

NOTREACHED();