third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp - Issue 2746783002: [ServiceWorker] Mojofy InstallEvent of Service Worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 2746783002: [ServiceWorker] Mojofy InstallEvent of Service Worker (Closed)

Patch Set: Fix the test failure Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h ('K') | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

index 36f288c29ea8ebcfd4b4901ebfe6e4a07cfaf0d6..5c111e5a2d27d02aa2ba2e9bf3d58dcd54fb534a 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

@@ -240,9 +240,10 @@ void ServiceWorkerGlobalScopeClientImpl::Navigate(

}

void ServiceWorkerGlobalScopeClientImpl::RegisterForeignFetchScopes(

+ int event_id,

horo 2017/04/27 09:22:21 nit: install_event_id

xiaofengzhang 2017/04/28 07:14:24 Done.

const WebVector<WebURL>& sub_scopes,

const WebVector<WebSecurityOrigin>& origins) {

- client_.RegisterForeignFetchScopes(sub_scopes, origins);

+ client_.RegisterForeignFetchScopes(event_id, sub_scopes, origins);

}

ServiceWorkerGlobalScopeClientImpl::ServiceWorkerGlobalScopeClientImpl(