Chromium Code Reviews| Index: third_party/WebKit/Source/modules/serviceworkers/InstallEvent.h |
| diff --git a/third_party/WebKit/Source/modules/serviceworkers/InstallEvent.h b/third_party/WebKit/Source/modules/serviceworkers/InstallEvent.h |
| index e2fb165655ac6a1a5dbe7bdd949762914746adb5..bb1511c9d0dfb611c28d98e9b4a058020c54dd72 100644 |
| --- a/third_party/WebKit/Source/modules/serviceworkers/InstallEvent.h |
| +++ b/third_party/WebKit/Source/modules/serviceworkers/InstallEvent.h |
| @@ -20,6 +20,7 @@ class MODULES_EXPORT InstallEvent : public ExtendableEvent { |
| const ExtendableEventInit&); |
| static InstallEvent* Create(const AtomicString& type, |
| const ExtendableEventInit&, |
| + const int event_id, |
|
leonhsl(Using Gerrit)
2017/04/23 03:33:10
No need to use 'const' for int type parameter here
xiaofengzhang
2017/04/24 05:02:41
Done.
|
| WaitUntilObserver*); |
| ~InstallEvent() override; |
| @@ -34,7 +35,9 @@ class MODULES_EXPORT InstallEvent : public ExtendableEvent { |
| InstallEvent(const AtomicString& type, const ExtendableEventInit&); |
| InstallEvent(const AtomicString& type, |
| const ExtendableEventInit&, |
| + const int event_id, |
|
shimazu
2017/04/24 05:00:13
Please remove this const,
|
| WaitUntilObserver*); |
| + int event_id_; |
|
shimazu
2017/04/24 05:00:13
and let's add const here.
xiaofengzhang
2017/04/25 06:01:29
Done.
|
| }; |
| } // namespace blink |