Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef InstallEvent_h | 5 #ifndef InstallEvent_h |
| 6 #define InstallEvent_h | 6 #define InstallEvent_h |
| 7 | 7 |
| 8 #include "modules/EventModules.h" | 8 #include "modules/EventModules.h" |
| 9 #include "modules/ModulesExport.h" | 9 #include "modules/ModulesExport.h" |
| 10 #include "modules/serviceworkers/ExtendableEvent.h" | 10 #include "modules/serviceworkers/ExtendableEvent.h" |
| 11 #include "modules/serviceworkers/ForeignFetchOptions.h" | 11 #include "modules/serviceworkers/ForeignFetchOptions.h" |
| 12 | 12 |
| 13 namespace blink { | 13 namespace blink { |
| 14 | 14 |
| 15 class MODULES_EXPORT InstallEvent : public ExtendableEvent { | 15 class MODULES_EXPORT InstallEvent : public ExtendableEvent { |
| 16 DEFINE_WRAPPERTYPEINFO(); | 16 DEFINE_WRAPPERTYPEINFO(); |
| 17 | 17 |
| 18 public: | 18 public: |
| 19 static InstallEvent* Create(const AtomicString& type, | 19 static InstallEvent* Create(const AtomicString& type, |
| 20 const ExtendableEventInit&); | 20 const ExtendableEventInit&); |
| 21 static InstallEvent* Create(const AtomicString& type, | 21 static InstallEvent* Create(const AtomicString& type, |
| 22 const ExtendableEventInit&, | 22 const ExtendableEventInit&, |
| 23 const int event_id, | |
|
leonhsl(Using Gerrit)
2017/04/23 03:33:10
No need to use 'const' for int type parameter here
xiaofengzhang
2017/04/24 05:02:41
Done.
| |
| 23 WaitUntilObserver*); | 24 WaitUntilObserver*); |
| 24 | 25 |
| 25 ~InstallEvent() override; | 26 ~InstallEvent() override; |
| 26 | 27 |
| 27 void registerForeignFetch(ScriptState*, | 28 void registerForeignFetch(ScriptState*, |
| 28 const ForeignFetchOptions&, | 29 const ForeignFetchOptions&, |
| 29 ExceptionState&); | 30 ExceptionState&); |
| 30 | 31 |
| 31 const AtomicString& InterfaceName() const override; | 32 const AtomicString& InterfaceName() const override; |
| 32 | 33 |
| 33 protected: | 34 protected: |
| 34 InstallEvent(const AtomicString& type, const ExtendableEventInit&); | 35 InstallEvent(const AtomicString& type, const ExtendableEventInit&); |
| 35 InstallEvent(const AtomicString& type, | 36 InstallEvent(const AtomicString& type, |
| 36 const ExtendableEventInit&, | 37 const ExtendableEventInit&, |
| 38 const int event_id, | |
|
shimazu
2017/04/24 05:00:13
Please remove this const,
| |
| 37 WaitUntilObserver*); | 39 WaitUntilObserver*); |
| 40 int event_id_; | |
|
shimazu
2017/04/24 05:00:13
and let's add const here.
xiaofengzhang
2017/04/25 06:01:29
Done.
| |
| 38 }; | 41 }; |
| 39 | 42 |
| 40 } // namespace blink | 43 } // namespace blink |
| 41 | 44 |
| 42 #endif // InstallEvent_h | 45 #endif // InstallEvent_h |
| OLD | NEW |