Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2746763009: Migrate WTF::Deque::prepend() to ::push_front() (Closed)

Created:
3 years, 9 months ago by pilgrim_google
Modified:
3 years, 9 months ago
CC:
Mads Ager (chromium), ajuma+watch_chromium.org, ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, kouhei+heap_chromium.org, Mikhail, oilpan-reviews, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, sof, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Deque::prepend() to ::push_front() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2746763009 Cr-Commit-Position: refs/heads/master@{#457140} Committed: https://chromium.googlesource.com/chromium/src/+/e76855dc3592add7faf7bff91b730385fc83cb16

Patch Set 1 #

Messages

Total messages: 14 (8 generated)
pilgrim_google
3 years, 9 months ago (2017-03-15 16:44:19 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-15 16:50:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746763009/1
3 years, 9 months ago (2017-03-15 16:53:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e76855dc3592add7faf7bff91b730385fc83cb16
3 years, 9 months ago (2017-03-15 18:10:33 UTC) #11
huangs
Please see https://codereview.chromium.org/2747373004/ , which I'm trying to revert, but this CL is in the ...
3 years, 9 months ago (2017-03-15 18:34:37 UTC) #13
huangs
3 years, 9 months ago (2017-03-15 18:37:35 UTC) #14
Message was sent while issue was closed.
Hmm, WebSiteSettingsPopupViewBrowserTest.ChromeURL crash disappeared.  Will do
nothing unless it returns.

Powered by Google App Engine
This is Rietveld 408576698