Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2746763007: Adds a factory function to ViewsDelegate for DesktopWindowTreeHost (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds a factory function to ViewsDelegate for DesktopWindowTreeHost There is at least one code path (html selects) that creates a DesktopNativeWidgetAura directly, and relies on DesktopWindowTreeHost::Create() being called. Problem is we can't wire up DesktopWindowTreeHost::Create() for ChromeOS (as mus is in a different compilation unit), so instead this adds another factory function to ViewsDelegate that if valid DesktopNativeWidgetAura uses to create the DesktopWindowTreeHost. BUG=701156 TEST=none R=erg@chromium.org Review-Url: https://codereview.chromium.org/2746763007 Cr-Commit-Position: refs/heads/master@{#456768} Committed: https://chromium.googlesource.com/chromium/src/+/b6eb9203f08cb87cdbaa93f7f6ea4b6b5a9dd41b

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -13 lines) Patch
M ui/views/mus/mus_client.h View 1 3 chunks +9 lines, -1 line 0 comments Download
M ui/views/mus/mus_client.cc View 1 4 chunks +15 lines, -4 lines 0 comments Download
M ui/views/views_delegate.h View 5 chunks +24 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +15 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_chromeos.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
3 years, 9 months ago (2017-03-14 17:10:44 UTC) #1
Elliot Glaysher
lgtm
3 years, 9 months ago (2017-03-14 17:18:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746763007/20001
3 years, 9 months ago (2017-03-14 17:33:11 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 18:31:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b6eb9203f08cb87cdbaa93f7f6ea...

Powered by Google App Engine
This is Rietveld 408576698