Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2746653002: net: make use of base::Erase() in AssembleRawHeaders() (Closed)

Created:
3 years, 9 months ago by tfarina
Modified:
3 years, 9 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: make use of base::Erase() in AssembleRawHeaders() This simplifies the code and makes it easier to understand for the casual reader. https://groups.google.com/a/chromium.org/d/msg/chromium-dev/QwLhUSk6kfI/HN5-df0-AwAJ BUG=None TEST=net_unittests R=eroman@chromium.org Review-Url: https://codereview.chromium.org/2746653002 Cr-Commit-Position: refs/heads/master@{#456246} Committed: https://chromium.googlesource.com/chromium/src/+/11e28fd6b9380b77273db51ef0b6ccc7ea341944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M net/http/http_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tfarina
3 years, 9 months ago (2017-03-10 23:56:52 UTC) #3
eroman
lgtm
3 years, 9 months ago (2017-03-11 00:00:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746653002/1
3 years, 9 months ago (2017-03-11 01:30:08 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 01:37:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/11e28fd6b9380b77273db51ef0b6...

Powered by Google App Engine
This is Rietveld 408576698