Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Issue 2746603003: Add UseCounter for overflow -webkit-paged-x and -webkit-paged-y. (Closed)

Created:
3 years, 9 months ago by ikilpatrick
Modified:
3 years, 9 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, asvitkine+watch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, blink-reviews-frames_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounter for overflow -webkit-paged-x and -webkit-paged-y. Adding the UseCounter to have better data if we would want to depcrecate and remove at some point. This isn't in any current CSS specification in this form. Review-Url: https://codereview.chromium.org/2746603003 Cr-Commit-Position: refs/heads/master@{#457241} Committed: https://chromium.googlesource.com/chromium/src/+/547e8815cd7549b2cd54c3ae2f959efc0b761fab

Patch Set 1 #

Patch Set 2 : rebase + add missing import. #

Patch Set 3 : rebase. #

Patch Set 4 : rebase number two! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 2 3 3 chunks +3 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
ikilpatrick
(first usecounter patch btw, hopefully I've done it right...)
3 years, 9 months ago (2017-03-10 21:22:00 UTC) #3
eae
LGTM
3 years, 9 months ago (2017-03-12 02:20:57 UTC) #4
foolip
lgtm
3 years, 9 months ago (2017-03-14 14:31:25 UTC) #5
ikilpatrick
+ericwilligers/haraken for histograms.xml
3 years, 9 months ago (2017-03-15 00:23:27 UTC) #7
haraken
LGTM
3 years, 9 months ago (2017-03-15 07:24:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746603003/40001
3 years, 9 months ago (2017-03-15 15:48:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/173010)
3 years, 9 months ago (2017-03-15 17:07:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746603003/40001
3 years, 9 months ago (2017-03-15 19:38:21 UTC) #15
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-15 20:17:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746603003/60001
3 years, 9 months ago (2017-03-15 20:51:28 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 22:37:03 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/547e8815cd7549b2cd54c3ae2f95...

Powered by Google App Engine
This is Rietveld 408576698