Enable native accessible touch support inside of ARC

Enable native accessible touch support inside of ARC

TEST=manual. With the --enable-chromevox-arc-support flag set on, touch explore within a shell surface and across to the shelf. Observe proper spoken feedback. Additionally, use multi finger gestures and observe proper dispatch of events to ChromeVox e.g. one finger swipe moves linearly.

Without the flag, do the same and observe Talkback spoken feedback within shell surface and ChromeVox feedback on shelf.
BUG=683396
Review-Url: https://codereview.chromium.org/2746543004
Cr-Commit-Position: refs/heads/master@{#459185}
Committed: https://chromium.googlesource.com/chromium/src/+/d36c05b57d332e75f5e01a43bde92ed55ad54ba5

[David Tseng, 2017-03-10 22:20:36]

Description was changed from

==========
Enable native accessible touch support inside of ARC

TEST=manual. With the --enable-chromevox-arc-support flag set on, touch explore
within a shell surface and across to the shelf. Observe proper spoken feedback.
BUG=
==========

to

==========
Enable native accessible touch support inside of ARC

TEST=manual. With the --enable-chromevox-arc-support flag set on, touch explore
within a shell surface and across to the shelf. Observe proper spoken feedback.
BUG=683396
==========

[David Tseng, 2017-03-10 22:20:36]

dtseng@chromium.org changed reviewers:
+ oshima@chromium.org, reveman@chromium.org

[David Tseng, 2017-03-10 22:21:09]

reveman for exo
oshima for ash
yawano as FYI

Thanks!

[David Tseng, 2017-03-10 22:22:23]

Description was changed from

==========
Enable native accessible touch support inside of ARC

TEST=manual. With the --enable-chromevox-arc-support flag set on, touch explore
within a shell surface and across to the shelf. Observe proper spoken feedback.
BUG=683396
==========

to

==========
Enable native accessible touch support inside of ARC

TEST=manual. With the --enable-chromevox-arc-support flag set on, touch explore
within a shell surface and across to the shelf. Observe proper spoken feedback.
Additionally, use multi finger gestures and observe proper dispatch of events to
ChromeVox e.g. one finger swipe moves linearly.

Without the flag, do the same and observe Talkback spoken feedback within shell
surface and ChromeVox feedback on shelf.
BUG=683396
==========

[reveman, 2017-03-13 16:59:58]

https://codereview.chromium.org/2746543004/diff/1/ash/ash_touch_exploration_m...
File ash/ash_touch_exploration_manager_chromeos.cc (right):

https://codereview.chromium.org/2746543004/diff/1/ash/ash_touch_exploration_m...
ash/ash_touch_exploration_manager_chromeos.cc:139:
!base::CommandLine::ForCurrentProcess()->HasSwitch(
I think you also need to check that the shell surface is actually an arc shell
surface before you consider this option. You'll need to get the application id
and check that it has a "org.chromium.arc." prefix.

[David Tseng, 2017-03-16 20:00:37]

PTAL

https://codereview.chromium.org/2746543004/diff/1/ash/ash_touch_exploration_m...
File ash/ash_touch_exploration_manager_chromeos.cc (right):

https://codereview.chromium.org/2746543004/diff/1/ash/ash_touch_exploration_m...
ash/ash_touch_exploration_manager_chromeos.cc:139:
!base::CommandLine::ForCurrentProcess()->HasSwitch(
On 2017/03/13 16:59:58, reveman wrote:
> I think you also need to check that the shell surface is actually an arc shell
> surface before you consider this option. You'll need to get the application id
> and check that it has a "org.chromium.arc." prefix.

I modified the check above (which indicates a pass through surface) to directly
check the new window property for arc app type.

[reveman, 2017-03-16 22:42:20]

lgtm after fixing possible performance problem

https://codereview.chromium.org/2746543004/diff/20001/ash/ash_touch_explorati...
File ash/ash_touch_exploration_manager_chromeos.cc (right):

https://codereview.chromium.org/2746543004/diff/20001/ash/ash_touch_explorati...
ash/ash_touch_exploration_manager_chromeos.cc:143:
chromeos::switches::kEnableChromeVoxArcSupport);
nit: maybe check this command line switch in the ctor instead of everytime this
function is called?

[David Tseng, 2017-03-20 16:38:02]

dtseng@chromium.org changed reviewers:
+ derat@chromium.org
- oshima@chromium.org

[David Tseng, 2017-03-20 16:38:03]

+ derat for ash. PTAL.

https://codereview.chromium.org/2746543004/diff/20001/ash/ash_touch_explorati...
File ash/ash_touch_exploration_manager_chromeos.cc (right):

https://codereview.chromium.org/2746543004/diff/20001/ash/ash_touch_explorati...
ash/ash_touch_exploration_manager_chromeos.cc:143:
chromeos::switches::kEnableChromeVoxArcSupport);
On 2017/03/16 22:42:19, reveman wrote:
> nit: maybe check this command line switch in the ctor instead of everytime
this
> function is called?

Shouldn't be an issue (this function gets called on construction, mode changes,
and window activation). Window activation should be most frequent, but shouldn't
be that frequent. I added it as a member field initialized in  the ctor though
just incase.

[David Tseng, 2017-03-20 18:04:11]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 18:05:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 18:59:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 18:59:03]

Dry run: This issue passed the CQ dry run.

[David Tseng, 2017-03-23 18:04:18]

dtseng@chromium.org changed reviewers:
+ jamescook@chromium.org, oshima@chromium.org

[David Tseng, 2017-03-23 18:04:18]

Friendly ping for an RS of ash.

[James Cook, 2017-03-23 19:03:54]

ash LGTM with nit

https://codereview.chromium.org/2746543004/diff/40001/ash/ash_touch_explorati...
File ash/ash_touch_exploration_manager_chromeos.h (right):

https://codereview.chromium.org/2746543004/diff/40001/ash/ash_touch_explorati...
ash/ash_touch_exploration_manager_chromeos.h:79: bool
enable_chromevox_arc_support_;
nit: const

[David Tseng, 2017-03-23 19:14:41]

b

https://codereview.chromium.org/2746543004/diff/40001/ash/ash_touch_explorati...
File ash/ash_touch_exploration_manager_chromeos.h (right):

https://codereview.chromium.org/2746543004/diff/40001/ash/ash_touch_explorati...
ash/ash_touch_exploration_manager_chromeos.h:79: bool
enable_chromevox_arc_support_;
On 2017/03/23 19:03:54, James Cook wrote:
> nit: const

Done.

[David Tseng, 2017-03-23 19:14:56]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-03-23 19:14:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2746543004/#ps60001
(title: "Address nit.")

[commit-bot: I haz the power, 2017-03-23 19:15:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:48:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490296496749490,
"parent_rev": "2c0190094a3b30cd7dc4c72c129e87296790e37e", "commit_rev":
"d36c05b57d332e75f5e01a43bde92ed55ad54ba5"}

[commit-bot: I haz the power, 2017-03-23 19:49:00]

Description was changed from

==========
Enable native accessible touch support inside of ARC

TEST=manual. With the --enable-chromevox-arc-support flag set on, touch explore
within a shell surface and across to the shelf. Observe proper spoken feedback.
Additionally, use multi finger gestures and observe proper dispatch of events to
ChromeVox e.g. one finger swipe moves linearly.

Without the flag, do the same and observe Talkback spoken feedback within shell
surface and ChromeVox feedback on shelf.
BUG=683396
==========

to

==========
Enable native accessible touch support inside of ARC

TEST=manual. With the --enable-chromevox-arc-support flag set on, touch explore
within a shell surface and across to the shelf. Observe proper spoken feedback.
Additionally, use multi finger gestures and observe proper dispatch of events to
ChromeVox e.g. one finger swipe moves linearly.

Without the flag, do the same and observe Talkback spoken feedback within shell
surface and ChromeVox feedback on shelf.
BUG=683396

Review-Url: https://codereview.chromium.org/2746543004
Cr-Commit-Position: refs/heads/master@{#459185}
Committed:
https://chromium.googlesource.com/chromium/src/+/d36c05b57d332e75f5e01a43bde9...
==========

[commit-bot: I haz the power, 2017-03-23 19:49:02]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d36c05b57d332e75f5e01a43bde9...