Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2746523002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 8 months ago
Reviewers:
palmer, agl
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (ssl, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=agl@chromium.org Review-Url: https://codereview.chromium.org/2746523002 Cr-Commit-Position: refs/heads/master@{#460802} Committed: https://chromium.googlesource.com/chromium/src/+/a78983cb7f095d0947b7bd59c68bea0e68619306

Patch Set 1 #

Patch Set 2 : add empty line #

Patch Set 3 : update component #

Patch Set 4 : update component #

Total comments: 2

Patch Set 5 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/ssl/OWNERS View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M components/ssl_errors/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/ssl/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/zlib/OWNERS View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-09 23:10:05 UTC) #1
ymzhang1
Update component in chrome/browser/ssl/OWNERS
3 years, 9 months ago (2017-03-09 23:12:08 UTC) #2
ymzhang1
update component in components/ssl_errors/OWNERS
3 years, 9 months ago (2017-03-09 23:40:07 UTC) #3
agl
https://codereview.chromium.org/2746523002/diff/60001/third_party/zlib/OWNERS File third_party/zlib/OWNERS (right): https://codereview.chromium.org/2746523002/diff/60001/third_party/zlib/OWNERS#newcode5 third_party/zlib/OWNERS:5: # COMPONENT: Internals>Network>SSL zlib is nothing to do with ...
3 years, 9 months ago (2017-03-10 00:00:03 UTC) #4
ymzhang1
Thanks for the comment! https://codereview.chromium.org/2746523002/diff/60001/third_party/zlib/OWNERS File third_party/zlib/OWNERS (right): https://codereview.chromium.org/2746523002/diff/60001/third_party/zlib/OWNERS#newcode5 third_party/zlib/OWNERS:5: # COMPONENT: Internals>Network>SSL On 2017/03/10 ...
3 years, 9 months ago (2017-03-10 00:03:57 UTC) #5
ymzhang1
Update reviewers list.
3 years, 9 months ago (2017-03-13 20:36:42 UTC) #7
palmer
lgtm
3 years, 8 months ago (2017-03-30 01:27:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746523002/80001
3 years, 8 months ago (2017-03-30 01:58:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/398325)
3 years, 8 months ago (2017-03-30 02:08:29 UTC) #12
agl
lgtm
3 years, 8 months ago (2017-03-30 16:54:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746523002/80001
3 years, 8 months ago (2017-03-30 16:55:22 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 17:04:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a78983cb7f095d0947b7bd59c68b...

Powered by Google App Engine
This is Rietveld 408576698