[css-align] Adapt self-alignment properties to the new baseline syntax

[css-align] Adapt self-alignment properties to the new baseline syntax

The baseline-position syntax has changed recently, so we need to update
the CSS properties using the old syntax. This patch address only the
self-alignment (align-self and justify-self) and default-alignment
(align-items and justify-items).

The content-distribution properties (align-content and justify-content)
will be updated in a follow up patch.

The new baseline syntax is "[first | last ]? baseline" which implies
modifying the parsing and computed value logic.

There are several layout tests affected by this change, so I'll update
them accordingly.


BUG=565883
Review-Url: https://codereview.chromium.org/2746453005
Cr-Commit-Position: refs/heads/master@{#456396}
Committed: https://chromium.googlesource.com/chromium/src/+/8f14d92d9469f4e87c3d3cfb2d8af8e8c9d8b727

[jfernandez, 2017-03-10 00:31:17]

Description was changed from

==========
[css-align] Adapt self-alignment properties to the new baseline syntax

The baseline-position syntax has changed recently, so we need to update
the CSS properties using the old syntax. This patch address only the
self-alignment (align-self and justify-self) and default-alignment
(align-items and justify-items).

The content-distribution properties (align-content and justify-content)
will be updated in a follow up patch.

The new baseline syntax is "[first | last ]? baseline" which implies
modifying the parsing and computed value logic.

There are several layout tests affected by this change, so I'll update
them accordingly.


BUG=565883
==========

to

==========
[css-align] Adapt self-alignment properties to the new baseline syntax

The baseline-position syntax has changed recently, so we need to update
the CSS properties using the old syntax. This patch address only the
self-alignment (align-self and justify-self) and default-alignment
(align-items and justify-items).

The content-distribution properties (align-content and justify-content)
will be updated in a follow up patch.

The new baseline syntax is "[first | last ]? baseline" which implies
modifying the parsing and computed value logic.

There are several layout tests affected by this change, so I'll update
them accordingly.


BUG=565883
==========

[jfernandez, 2017-03-10 00:31:17]

jfernandez@igalia.com changed reviewers:
+ meade@chromium.org, rego@igalia.com, svillar@igalia.com

[jfernandez, 2017-03-10 00:31:27]

PTAL

[meade_UTC10, 2017-03-10 04:13:53]

lgtm with nits about the tests. I realise the tests were already very
monolithic, so if you prefer to update in a later CL, that's fine by me.

https://codereview.chromium.org/2746453005/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html
(right):

https://codereview.chromium.org/2746453005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html:158: },
"Test getting align-items set through CSS.");
Can this test be broken up a bit? I generally find where one test has many
things checked in it, if it fails, it's much harder to debug than writing lots
of small tests. Ditto for the rest of this file, and other tests in this CL.

[jfernandez, 2017-03-10 08:54:56]

Thanks for the review. 
Now that you mention the issues with the tests, I'm working on new tests for the
CSS Box Alignment feature in csswg-test repository:

https://github.com/w3c/csswg-test/tree/master/css-align-3

The idea would be to import then regularly and perhaps we can remove the ones we
already have.

https://codereview.chromium.org/2746453005/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html
(right):

https://codereview.chromium.org/2746453005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/alignment/parse-align-items.html:158: },
"Test getting align-items set through CSS.");
On 2017/03/10 04:13:53, Eddy wrote:
> Can this test be broken up a bit? I generally find where one test has many
> things checked in it, if it fails, it's much harder to debug than writing lots
> of small tests. Ditto for the rest of this file, and other tests in this CL.

Yes, I agree. 
We have more or less the same problem for all the alignment related tests.

[jfernandez, 2017-03-10 08:57:30]

The CQ bit was checked by jfernandez@igalia.com

[commit-bot: I haz the power, 2017-03-10 08:57:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 10:30:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 10:30:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jfernandez, 2017-03-13 11:50:17]

The CQ bit was checked by jfernandez@igalia.com

[jfernandez, 2017-03-13 11:50:18]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2746453005/#ps20001
(title: "Fixed layout test failures.")

[commit-bot: I haz the power, 2017-03-13 11:50:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 13:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 13:29:22]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jfernandez, 2017-03-13 14:18:37]

The CQ bit was checked by jfernandez@igalia.com

[jfernandez, 2017-03-13 14:18:37]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2746453005/#ps40001
(title: "More layout tests fixes.")

[commit-bot: I haz the power, 2017-03-13 14:18:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 16:26:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489414717065350,
"parent_rev": "109e10b0a48a1f09d242562611c2556b12a29da6", "commit_rev":
"8f14d92d9469f4e87c3d3cfb2d8af8e8c9d8b727"}

[commit-bot: I haz the power, 2017-03-13 16:27:37]

Description was changed from

==========
[css-align] Adapt self-alignment properties to the new baseline syntax

The baseline-position syntax has changed recently, so we need to update
the CSS properties using the old syntax. This patch address only the
self-alignment (align-self and justify-self) and default-alignment
(align-items and justify-items).

The content-distribution properties (align-content and justify-content)
will be updated in a follow up patch.

The new baseline syntax is "[first | last ]? baseline" which implies
modifying the parsing and computed value logic.

There are several layout tests affected by this change, so I'll update
them accordingly.


BUG=565883
==========

to

==========
[css-align] Adapt self-alignment properties to the new baseline syntax

The baseline-position syntax has changed recently, so we need to update
the CSS properties using the old syntax. This patch address only the
self-alignment (align-self and justify-self) and default-alignment
(align-items and justify-items).

The content-distribution properties (align-content and justify-content)
will be updated in a follow up patch.

The new baseline syntax is "[first | last ]? baseline" which implies
modifying the parsing and computed value logic.

There are several layout tests affected by this change, so I'll update
them accordingly.


BUG=565883

Review-Url: https://codereview.chromium.org/2746453005
Cr-Commit-Position: refs/heads/master@{#456396}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f14d92d9469f4e87c3d3cfb2d8a...
==========

[commit-bot: I haz the power, 2017-03-13 16:27:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8f14d92d9469f4e87c3d3cfb2d8a...