Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2746433004: Re-enable support for Math in ChromeVox Next (Closed)

Created:
3 years, 9 months ago by David Tseng
Modified:
3 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable support for Math in ChromeVox Next TEST=navigate to mathjax.org. Tab to the first math expression. Observe help message (prompting to hit shift+space). Verify exploration (arrow keys) leads to verbal output. BUG=624124 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2746433004 Cr-Commit-Position: refs/heads/master@{#456482} Committed: https://chromium.googlesource.com/chromium/src/+/18bea6fa79ca4c32405f844aeb660d0070bdf5c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
David Tseng
3 years, 9 months ago (2017-03-10 23:38:18 UTC) #5
dmazzoni
lgtm
3 years, 9 months ago (2017-03-13 16:22:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746433004/1
3 years, 9 months ago (2017-03-13 20:01:42 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 21:10:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18bea6fa79ca4c32405f844aeb66...

Powered by Google App Engine
This is Rietveld 408576698