cc: Pick the biggest Quad when selecting an overlay.

cc: Pick the biggest Quad when selecting an overlay.

When selecting an overlay with OverlayStrategySingleOnTop, that picks
only one quad to be used as HW overlays, prefer a bigger quad than
a small one.

This is convenient in cases where we get buffers from exo, where one
buffer reprents a title bar and one the content.
Before this patch we might have schedule the title bar as HW overlay
since it comes first in the rendering order.
After this CL we should prioritize the content.

BUG=695296
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2746393005
Cr-Commit-Position: refs/heads/master@{#457079}
Committed: https://chromium.googlesource.com/chromium/src/+/786f5cde9ec32c296aa372006df3fa3e07dd03be

[Daniele Castagna, 2017-03-15 00:44:19]

Description was changed from

==========
cc: Pick the biggest rect when selecting an overlay.

When selecting an overlay with OverlayStrategySingleOnTop, that picks
only one quad to be used as HW overlays, prefer a bigger quad than
a small one.

This is convenient in cases where we get buffers from exo, where one
buffer reprents a title bar and one the content.
Before his patch we might schedule the title bar since it comes first
in the quadlist order. With this CL we should prioritize the content.

BUG=695296
==========

to

==========
cc: Pick the biggest rect when selecting an overlay.

When selecting an overlay with OverlayStrategySingleOnTop, that picks
only one quad to be used as HW overlays, prefer a bigger quad than
a small one.

This is convenient in cases where we get buffers from exo, where one
buffer reprents a title bar and one the content.
Before his patch we might schedule the title bar since it comes first
in the quadlist order. With this CL we should prioritize the content.

BUG=695296
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Daniele Castagna, 2017-03-15 00:45:25]

Description was changed from

==========
cc: Pick the biggest rect when selecting an overlay.

When selecting an overlay with OverlayStrategySingleOnTop, that picks
only one quad to be used as HW overlays, prefer a bigger quad than
a small one.

This is convenient in cases where we get buffers from exo, where one
buffer reprents a title bar and one the content.
Before his patch we might schedule the title bar since it comes first
in the quadlist order. With this CL we should prioritize the content.

BUG=695296
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Pick the biggest Quad when selecting an overlay.

When selecting an overlay with OverlayStrategySingleOnTop, that picks
only one quad to be used as HW overlays, prefer a bigger quad than
a small one.

This is convenient in cases where we get buffers from exo, where one
buffer reprents a title bar and one the content.
Before this patch we might have schedule the title bar as HW overlay
since it comes first in the rendering order.
After this CL we should prioritize the content.

BUG=695296
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Daniele Castagna, 2017-03-15 00:45:44]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[Daniele Castagna, 2017-03-15 00:45:44]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org

[commit-bot: I haz the power, 2017-03-15 00:46:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 00:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 00:54:19]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Daniele Castagna, 2017-03-15 04:50:35]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 04:50:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 05:38:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 05:38:31]

Dry run: This issue passed the CQ dry run.

[Daniele Castagna, 2017-03-15 05:40:42]

PTAL.
The code has been simplified as we discussed offline. We now just pick the
biggest overlay candidate and try to validate only that one.

[reveman, 2017-03-15 12:18:38]

lgtm

[Daniele Castagna, 2017-03-15 14:55:55]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2017-03-15 14:56:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 14:59:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489589755481910,
"parent_rev": "af306bc59987517122f77e9d5eac87ff61c374aa", "commit_rev":
"786f5cde9ec32c296aa372006df3fa3e07dd03be"}

[commit-bot: I haz the power, 2017-03-15 15:00:15]

Description was changed from

==========
cc: Pick the biggest Quad when selecting an overlay.

When selecting an overlay with OverlayStrategySingleOnTop, that picks
only one quad to be used as HW overlays, prefer a bigger quad than
a small one.

This is convenient in cases where we get buffers from exo, where one
buffer reprents a title bar and one the content.
Before this patch we might have schedule the title bar as HW overlay
since it comes first in the rendering order.
After this CL we should prioritize the content.

BUG=695296
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Pick the biggest Quad when selecting an overlay.

When selecting an overlay with OverlayStrategySingleOnTop, that picks
only one quad to be used as HW overlays, prefer a bigger quad than
a small one.

This is convenient in cases where we get buffers from exo, where one
buffer reprents a title bar and one the content.
Before this patch we might have schedule the title bar as HW overlay
since it comes first in the rendering order.
After this CL we should prioritize the content.

BUG=695296
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2746393005
Cr-Commit-Position: refs/heads/master@{#457079}
Committed:
https://chromium.googlesource.com/chromium/src/+/786f5cde9ec32c296aa372006df3...
==========

[commit-bot: I haz the power, 2017-03-15 15:00:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/786f5cde9ec32c296aa372006df3...