Add FetchMore to Content Suggestions Mediator

Add FetchMore to Content Suggestions Mediator

This CL adds a FetchMoreSuggestions methods to the ContentSuggestionsMediator,
returning the more data for a section.

BUG=700296
Review-Url: https://codereview.chromium.org/2746373004
Cr-Commit-Position: refs/heads/master@{#457067}
Committed: https://chromium.googlesource.com/chromium/src/+/cdfbf3ba453a5c0d9c67a4d793f1b2cd01ea7393

[gambard, 2017-03-14 16:10:11]

gambard@chromium.org changed reviewers:
+ lpromero@chromium.org

[gambard, 2017-03-14 16:10:11]

PTAL.

[lpromero, 2017-03-14 16:24:47]

Description was changed from

==========
Add FetchMore to Content Suggestions Mediator

This CL adds a FetchMoreSuggestions methods to the ContentSuggestionsMediator,
returing the more data for a section.

BUG=700296
==========

to

==========
Add FetchMore to Content Suggestions Mediator

This CL adds a FetchMoreSuggestions methods to the ContentSuggestionsMediator,
returning the more data for a section.

BUG=700296
==========

[lpromero, 2017-03-14 16:33:08]

lgtm

https://codereview.chromium.org/2746373004/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
(right):

https://codereview.chromium.org/2746373004/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:28: //
TODO(crbug.com/701275):Once base::BindBlock supports the move semantics,
Add a space after the colon.

[gambard, 2017-03-15 09:53:36]

Thanks! I have rebased, introducing more changes.

https://codereview.chromium.org/2746373004/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
(right):

https://codereview.chromium.org/2746373004/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:28: //
TODO(crbug.com/701275):Once base::BindBlock supports the move semantics,
On 2017/03/14 16:33:08, lpromero wrote:
> Add a space after the colon.

Done.

[lpromero, 2017-03-15 10:18:09]

lgtm

https://codereview.chromium.org/2746373004/diff/40001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h
(right):

https://codereview.chromium.org/2746373004/diff/40001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h:37:
// called with the updated content.
"contents" to match line 35? Can you precise if the updated contents is just the
diff, or the entire contents?

[gambard, 2017-03-15 13:14:15]

Thanks!

https://codereview.chromium.org/2746373004/diff/40001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h
(right):

https://codereview.chromium.org/2746373004/diff/40001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h:37:
// called with the updated content.
On 2017/03/15 10:18:09, lpromero wrote:
> "contents" to match line 35? Can you precise if the updated contents is just
the
> diff, or the entire contents?

Updated.

[gambard, 2017-03-15 13:21:04]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-03-15 13:21:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2746373004/#ps60001
(title: "Address comment")

[commit-bot: I haz the power, 2017-03-15 13:21:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 13:34:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489584064779680,
"parent_rev": "354f42fea111d3fc28d206c69fba4514aed1a849", "commit_rev":
"cdfbf3ba453a5c0d9c67a4d793f1b2cd01ea7393"}

[commit-bot: I haz the power, 2017-03-15 13:35:10]

Description was changed from

==========
Add FetchMore to Content Suggestions Mediator

This CL adds a FetchMoreSuggestions methods to the ContentSuggestionsMediator,
returning the more data for a section.

BUG=700296
==========

to

==========
Add FetchMore to Content Suggestions Mediator

This CL adds a FetchMoreSuggestions methods to the ContentSuggestionsMediator,
returning the more data for a section.

BUG=700296

Review-Url: https://codereview.chromium.org/2746373004
Cr-Commit-Position: refs/heads/master@{#457067}
Committed:
https://chromium.googlesource.com/chromium/src/+/cdfbf3ba453a5c0d9c67a4d793f1...
==========

[commit-bot: I haz the power, 2017-03-15 13:35:11]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cdfbf3ba453a5c0d9c67a4d793f1...