Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2746363013: [MD Bookmarks] Add a drag and drop indicator to bookmarks. (Closed)

Created:
3 years, 9 months ago by calamity
Modified:
3 years, 8 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, extensions-reviews_chromium.org, dcheng, michaelpg+watch-md-ui_chromium.org, jlklein+watch-closure_chromium.org, chromium-apps-reviews_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Add a drag and drop indicator to bookmarks. This CL adds an indicator for dragging and dropping bookmarks. This indicator will highlight folders that can be dragged onto and add a line above/below items for dragging between items. This affects both the list and the sidebar, and bookmark elements in both are now draggable. BUG=692843 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2746363013 Cr-Commit-Position: refs/heads/master@{#460626} Committed: https://chromium.googlesource.com/chromium/src/+/cc543e614e2362ae0e6881fbf5601c415e07c672

Patch Set 1 #

Patch Set 2 : #

Total comments: 22

Patch Set 3 : address comments, add test #

Total comments: 17

Patch Set 4 : address comments #

Patch Set 5 : rebase #

Total comments: 24

Patch Set 6 : address comments #

Total comments: 2

Patch Set 7 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1028 lines, -22 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/app.html View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/app.js View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/compiled_resources2.gyp View 1 2 3 4 3 chunks +15 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/dnd_manager.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/dnd_manager.js View 1 2 3 4 5 1 chunk +519 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/folder_node.html View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/folder_node.js View 1 2 3 4 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/item.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/item.js View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/reducers.js View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/shared_style.html View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/shared_vars.html View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/sidebar.html View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/types.js View 1 2 3 4 5 4 chunks +27 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/util.js View 1 2 3 2 chunks +27 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/webui/md_bookmarks/dnd_manager_test.js View 1 2 3 4 5 1 chunk +342 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/test_store.js View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 38 (25 generated)
calamity
Okay... This didn't end up being much smaller. The prototype is at https://codereview.chromium.org/2758703002/ . This ...
3 years, 9 months ago (2017-03-17 05:36:51 UTC) #3
tsergeant
First pass. At this stage I mostly understand what's going on, but I haven't necessarily ...
3 years, 9 months ago (2017-03-20 03:01:50 UTC) #4
calamity
https://codereview.chromium.org/2746363013/diff/20001/chrome/browser/resources/md_bookmarks/dnd_manager.html File chrome/browser/resources/md_bookmarks/dnd_manager.html (right): https://codereview.chromium.org/2746363013/diff/20001/chrome/browser/resources/md_bookmarks/dnd_manager.html#newcode4 chrome/browser/resources/md_bookmarks/dnd_manager.html:4: <dom-module id="bookmarks-dnd-manager"> On 2017/03/20 03:01:49, tsergeant wrote: > I ...
3 years, 9 months ago (2017-03-22 05:29:53 UTC) #7
tsergeant
You'll need to do a rebase -- there are minor conflicts in a few places ...
3 years, 9 months ago (2017-03-23 00:28:23 UTC) #8
calamity
The tests also picked up a few bugs which got fixed. Sidebar user-select CSS added. ...
3 years, 9 months ago (2017-03-23 06:12:34 UTC) #13
tsergeant
review haiku: big, complex CL eyes begin to glaze over here's a round of nits ...
3 years, 9 months ago (2017-03-27 06:49:23 UTC) #21
calamity
https://codereview.chromium.org/2746363013/diff/180001/chrome/browser/resources/md_bookmarks/dnd_manager.js File chrome/browser/resources/md_bookmarks/dnd_manager.js (right): https://codereview.chromium.org/2746363013/diff/180001/chrome/browser/resources/md_bookmarks/dnd_manager.js#newcode158 chrome/browser/resources/md_bookmarks/dnd_manager.js:158: * @type {function((Function|null|string), number)} On 2017/03/27 06:49:24, tsergeant wrote: ...
3 years, 8 months ago (2017-03-28 04:15:03 UTC) #22
tsergeant
lgtm with one last nit https://codereview.chromium.org/2746363013/diff/180001/chrome/browser/resources/md_bookmarks/dnd_manager.js File chrome/browser/resources/md_bookmarks/dnd_manager.js (right): https://codereview.chromium.org/2746363013/diff/180001/chrome/browser/resources/md_bookmarks/dnd_manager.js#newcode312 chrome/browser/resources/md_bookmarks/dnd_manager.js:312: var draggedNodes = Object.keys(state.selection.items); ...
3 years, 8 months ago (2017-03-28 23:52:22 UTC) #23
calamity
https://codereview.chromium.org/2746363013/diff/200001/chrome/browser/resources/md_bookmarks/sidebar.html File chrome/browser/resources/md_bookmarks/sidebar.html (right): https://codereview.chromium.org/2746363013/diff/200001/chrome/browser/resources/md_bookmarks/sidebar.html#newcode15 chrome/browser/resources/md_bookmarks/sidebar.html:15: user-select: none On 2017/03/28 23:52:22, tsergeant wrote: > Nit: ...
3 years, 8 months ago (2017-03-29 00:52:20 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746363013/220001
3 years, 8 months ago (2017-03-29 06:45:35 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/410558)
3 years, 8 months ago (2017-03-29 07:48:14 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746363013/220001
3 years, 8 months ago (2017-03-30 00:53:07 UTC) #35
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 02:15:54 UTC) #38
Message was sent while issue was closed.
Committed patchset #7 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/cc543e614e2362ae0e6881fbf560...

Powered by Google App Engine
This is Rietveld 408576698