Avoid leaks in pdfium_fuzzer by using unique_ptr<>

Avoid leaks in pdfium_fuzzer by using unique_ptr<>

BUG=702064
Review-Url: https://codereview.chromium.org/2746363009
Cr-Commit-Position: refs/heads/master@{#457838}
Committed: https://chromium.googlesource.com/chromium/src/+/e13fdde8bc0fbc7a85c7caa21fe2ff766ced836a

[Tom Sepez, 2017-03-16 22:34:34]

Description was changed from

==========
Avoid leaks in pdfium_fuzzer with unique_ptr<>

BUG=702064
==========

to

==========
Avoid leaks in pdfium_fuzzer by using unique_ptr<>

BUG=702064
==========

[Tom Sepez, 2017-03-16 22:34:35]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2017-03-16 22:34:48]

Dan for review (still waiting on roll).

[Tom Sepez, 2017-03-17 18:02:16]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[Tom Sepez, 2017-03-17 18:02:36]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2017-03-17 18:03:01]

Lei, because super-slow may be better than OOO friday.

[commit-bot: I haz the power, 2017-03-17 18:03:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 18:13:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 18:13:05]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-03-17 18:42:09]

lgtm

https://codereview.chromium.org/2746363009/diff/1/pdf/pdfium/fuzzers/pdfium_f...
File pdf/pdfium/fuzzers/pdfium_fuzzer.cc (right):

https://codereview.chromium.org/2746363009/diff/1/pdf/pdfium/fuzzers/pdfium_f...
pdf/pdfium/fuzzers/pdfium_fuzzer.cc:112: std::unique_ptr<void,
FPDFDocumentDeleter> doc;
Move this below |pdf_avail| so we preserve the same destruction order as before?

[Tom Sepez, 2017-03-17 18:47:06]

https://codereview.chromium.org/2746363009/diff/1/pdf/pdfium/fuzzers/pdfium_f...
File pdf/pdfium/fuzzers/pdfium_fuzzer.cc (right):

https://codereview.chromium.org/2746363009/diff/1/pdf/pdfium/fuzzers/pdfium_f...
pdf/pdfium/fuzzers/pdfium_fuzzer.cc:112: std::unique_ptr<void,
FPDFDocumentDeleter> doc;
On 2017/03/17 18:42:09, Lei Zhang (super slow) wrote:
> Move this below |pdf_avail| so we preserve the same destruction order as
before?

Done.

[Tom Sepez, 2017-03-17 18:47:31]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2017-03-17 18:47:31]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2746363009/#ps20001
(title: "destruction order")

[commit-bot: I haz the power, 2017-03-17 18:48:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 19:06:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489776451237850,
"parent_rev": "404ba0c71f7fe2b59657067a6d3f5f7909cd920d", "commit_rev":
"e13fdde8bc0fbc7a85c7caa21fe2ff766ced836a"}

[commit-bot: I haz the power, 2017-03-17 19:07:31]

Description was changed from

==========
Avoid leaks in pdfium_fuzzer by using unique_ptr<>

BUG=702064
==========

to

==========
Avoid leaks in pdfium_fuzzer by using unique_ptr<>

BUG=702064

Review-Url: https://codereview.chromium.org/2746363009
Cr-Commit-Position: refs/heads/master@{#457838}
Committed:
https://chromium.googlesource.com/chromium/src/+/e13fdde8bc0fbc7a85c7caa21fe2...
==========

[commit-bot: I haz the power, 2017-03-17 19:07:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e13fdde8bc0fbc7a85c7caa21fe2...