Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2746363008: gpu_tests: do not run info_collection on Mac Asan (Closed)

Created:
3 years, 9 months ago by Corentin Wallez
Modified:
3 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu_tests: do not run info_collection on Mac Asan The Mac ASAN swarming config includes two different GPU types which makes info_collection fail as there isn't a single device / vendor ID combinations possible. BUG=angleproject:1874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2746363008 Cr-Commit-Position: refs/heads/master@{#457478} Committed: https://chromium.googlesource.com/chromium/src/+/74a8e1b5da717c00e190aabc58c29b54430985c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -32 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 1 chunk +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Corentin Wallez
PTAL, this fixes/suppresses the failure of info_collection on Mac ASAN
3 years, 9 months ago (2017-03-16 15:00:54 UTC) #3
Ken Russell (switch to Gerrit)
Argh. Yes, I see, that's a problem. It works on the tryservers because they merge ...
3 years, 9 months ago (2017-03-16 17:24:12 UTC) #8
Corentin Wallez
Thanks!
3 years, 9 months ago (2017-03-16 17:24:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746363008/1
3 years, 9 months ago (2017-03-16 17:25:31 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 17:39:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/74a8e1b5da717c00e190aabc58c2...

Powered by Google App Engine
This is Rietveld 408576698