cipd2isolate: Initial CLI parsing boilerplate.

cipd2isolate: Initial CLI parsing boilerplate.

R=iannucci@chromium.org, nodir@chromium.org
BUG=701930
Review-Url: https://codereview.chromium.org/2746363007
Committed: https://github.com/luci/luci-go/commit/a3e2880ae6d94c2c37432d0c36d70256cf322760

[Vadim Sh., 2017-03-16 06:06:19]

PTAL

The resulting set of arguments:
./cipd2isolate isolate -help
Takes an 'ensure file' with description of some CIPD site root, and produces
*.isolated with same content

usage:  cipd2isolate isolate [options]
  -I string
    	Alias for -isolate-server
  -cipd-cache-dir string
    	Directory for shared CIPD cache (can also be set by CIPD_CACHE_DIR env
var).
  -cipd-ensure-file string
    	An "ensure" file with packages to isolate. See syntax described here:
https://godoc.org/github.com/luci/luci-go/cipd/client/cipd/ensure. Providing '-'
will read from stdin.
  -cipd-service-url string
    	CIPD Backend URL. If provided via an 'ensure file', the URL in the file
takes precedence. (default "https://chrome-infra-packages.appspot.com")
  -isolate-server string
    	Isolate server to use; defaults to value of $ISOLATE_SERVER; use special
value 'fake' to use a fake server
  -json-output string
    	Path to write operation results to.
  -namespace string
    	 (default "default-gzip")
  -service-account-json string
    	Path to JSON file with service account credentials to use.
  -verbose
    	Enable more logging.
  -work-dir string
    	A directory to keep temporary files in. (default "./c2i_work")

[nodir, 2017-03-16 18:57:34]

lgtm

https://codereview.chromium.org/2746363007/diff/1/cipd/client/cmd/cipd2isolat...
File cipd/client/cmd/cipd2isolate/main.go (right):

https://codereview.chromium.org/2746363007/diff/1/cipd/client/cmd/cipd2isolat...
cipd/client/cmd/cipd2isolate/main.go:75: "CIPD Backend URL. If provided via an
'ensure file', the URL in the file takes precedence.")
this is odd. Maybe make flag default "" and if it is passed, use it instead of
the url in ensure file

https://codereview.chromium.org/2746363007/diff/1/cipd/client/cmd/cipd2isolat...
cipd/client/cmd/cipd2isolate/main.go:161: defer f.Close()
i assume nothing bad is going to happen if you close stdin

[Vadim Sh., 2017-03-16 18:59:32]

https://codereview.chromium.org/2746363007/diff/1/cipd/client/cmd/cipd2isolat...
File cipd/client/cmd/cipd2isolate/main.go (right):

https://codereview.chromium.org/2746363007/diff/1/cipd/client/cmd/cipd2isolat...
cipd/client/cmd/cipd2isolate/main.go:75: "CIPD Backend URL. If provided via an
'ensure file', the URL in the file takes precedence.")
On 2017/03/16 18:57:34, nodir wrote:
> this is odd. Maybe make flag default "" and if it is passed, use it instead of
> the url in ensure file

I copied this from CIPD client. I forgot why it is so, but there were reasons...
(Note that we rarely use $ServiceURL in ensure files currently).

https://codereview.chromium.org/2746363007/diff/1/cipd/client/cmd/cipd2isolat...
cipd/client/cmd/cipd2isolate/main.go:161: defer f.Close()
On 2017/03/16 18:57:34, nodir wrote:
> i assume nothing bad is going to happen if you close stdin

yes, this is fine.

[Vadim Sh., 2017-03-16 18:59:36]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2017-03-16 18:59:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 19:05:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489690776809250, "parent_rev":
"e338a23839ca11507e06c121216c4843963cfb32", "commit_rev":
"a3e2880ae6d94c2c37432d0c36d70256cf322760"}

[commit-bot: I haz the power, 2017-03-16 19:05:59]

Description was changed from

==========
cipd2isolate: Initial CLI parsing boilerplate.

R=iannucci@chromium.org, nodir@chromium.org
BUG=701930
==========

to

==========
cipd2isolate: Initial CLI parsing boilerplate.

R=iannucci@chromium.org, nodir@chromium.org
BUG=701930

Review-Url: https://codereview.chromium.org/2746363007
Committed:
https://github.com/luci/luci-go/commit/a3e2880ae6d94c2c37432d0c36d70256cf322760
==========

[commit-bot: I haz the power, 2017-03-16 19:06:00]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/a3e2880ae6d94c2c37432d0c36d70256cf322760