Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2746333004: Revert of CSP: New test with form-action and a redirect into a new window. (Closed)

Created:
3 years, 9 months ago by arthursonzogni
Modified:
3 years, 9 months ago
Reviewers:
Mike West
CC:
alexmos, blink-reviews, chromium-reviews, clamy, jam, nasko
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CSP: New test with form-action and a redirect into a new window. (patchset #1 id:20001 of https://codereview.chromium.org/2747823002/ ) Reason for revert: It looks like the test is passing with site-isolation, so they have the wrong file expectation. There is also a minor problem when accessing namedWindow.location.href. I will fix the test and try to understand why it seems to work with site-isolation. Original issue's description: > CSP: New test with form-action and a redirect into a new window. > > This test shows that the CSP of the navigating frame are used instead of > the CSP of the frame that has initiated the navigation. > > BUG=700964 > > Review-Url: https://codereview.chromium.org/2747823002 > Cr-Commit-Position: refs/heads/master@{#456656} > Committed: https://chromium.googlesource.com/chromium/src/+/def680801ab5c196b089e67a6e2a1d3768b4a7d3 TBR=mkwst@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=700964 Review-Url: https://codereview.chromium.org/2746333004 Cr-Commit-Position: refs/heads/master@{#456731} Committed: https://chromium.googlesource.com/chromium/src/+/6d372536c2e57165dc222454188e1f54371c7053

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
arthursonzogni
Created Revert of CSP: New test with form-action and a redirect into a new window.
3 years, 9 months ago (2017-03-14 16:45:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746333004/1
3 years, 9 months ago (2017-03-14 16:45:32 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 16:47:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6d372536c2e57165dc222454188e...

Powered by Google App Engine
This is Rietveld 408576698