Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: device/vr/vr_device_manager.h

Issue 2746233002: Fixes 2D-to-WebVR site transitions when browsing in VR. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/vr_device_manager.h
diff --git a/device/vr/vr_device_manager.h b/device/vr/vr_device_manager.h
index 202cd847b6bb9c7d0d54c6f97bf9abe596e1ada2..a9be40e9ded24430eeb35952cbea89cf0fbbd76b 100644
--- a/device/vr/vr_device_manager.h
+++ b/device/vr/vr_device_manager.h
@@ -24,6 +24,7 @@
namespace device {
+// Singleton used to provide the system's VR devices to VRServiceImpl instances.
mthiesse 2017/03/13 22:17:29 nit: s/system/platform/?
tiborg 2017/03/13 23:00:58 Done.
class VRDeviceManager {
public:
DEVICE_VR_EXPORT virtual ~VRDeviceManager();
@@ -32,11 +33,11 @@ class VRDeviceManager {
static VRDeviceManager* GetInstance();
// Adds a listener for device manager events. VRDeviceManager does not own
- // this object.
+ // this object. Automatically connects all currently available VR devices to
amp 2017/03/13 22:26:05 That's quite an additional comment here. Can we a
tiborg 2017/03/13 23:00:58 Elaborated a bit. Is this more understandable?
amp 2017/03/14 17:05:50 Yes, it doesn't sound like magic now. :)
+ // this service.
void AddService(VRServiceImpl* service);
void RemoveService(VRServiceImpl* service);
- DEVICE_VR_EXPORT bool GetVRDevices(VRServiceImpl* service);
DEVICE_VR_EXPORT unsigned int GetNumberOfConnectedDevices();
void ListeningForActivateChanged(bool listening);

Powered by Google App Engine
This is Rietveld 408576698