Fixes 2D-to-WebVR site transitions when browsing in VR.

device/vr/vr_device.h

Index: device/vr/vr_device.h
diff --git a/device/vr/vr_device.h b/device/vr/vr_device.h
index be836ee12016272cdbcb11abc704cd63380d2396..39c406ebd44042fe073e3a0391d61efa2d5ed555 100644
--- a/device/vr/vr_device.h
+++ b/device/vr/vr_device.h
@@ -16,6 +16,8 @@ class VRDisplayImpl;
 
 const unsigned int VR_DEVICE_LAST_ID = 0xFFFFFFFF;
 
+// Represents a VR device in the system. Owned by the respective

[mthiesse, 2017/03/13 22:17:29]

What does "a VR device in the system" mean?

[tiborg, 2017/03/13 23:00:58]

I mean one of all the available VR devices. Changed it to platform.

+// VRDeviceProvider.
 class DEVICE_VR_EXPORT VRDevice {
  public:
   VRDevice();
@@ -23,8 +25,11 @@ class DEVICE_VR_EXPORT VRDevice {
 
   unsigned int id() const { return id_; }
 
-  virtual void GetVRDevice(
-      const base::Callback<void(mojom::VRDisplayInfoPtr)>& callback) = 0;
+  // Queries VR device for display info and calls onCreated once the  display

[mthiesse, 2017/03/13 22:17:29]

nit: s/  display/ display/

[tiborg, 2017/03/13 23:00:58]

Done.

+  // info object is created. May or may not call onCreated before this

[amp, 2017/03/13 22:26:05]

The last sentence here makes it sound like the creation can fail sometime and
then won't callback (and doesn't explain those scenarios).  Is this instead
saying that the callback is asynchronous?

[tiborg, 2017/03/13 23:00:58]

I wanted to say that the callback can be called on top of the stack of this
function even though you kinda assume the callback would be called sometimes
later (that's why the DisplayInfoPtr is not the return type). Changed it a bit.
Does this make sense?

[amp, 2017/03/14 17:05:50]

Yes that clarifies the scenarios I was wondering about, thanks.

+  // function returns.
+  virtual void CreateVRDisplayInfo(
+      const base::Callback<void(mojom::VRDisplayInfoPtr)>& onCreated) = 0;
   virtual void ResetPose() = 0;
 
   virtual void RequestPresent(const base::Callback<void(bool)>& callback) = 0;