Enable control over frame time in SimTests

Enable control over frame time in SimTests

This change adds beginFrame(double timeDelta) to SimCompositor to allow
SimTests to control the time progression used by each frame.
This is in preparation for adding animation SimTests.

This change also fixes a bug in the beginFrame() implementation where
it used monotonicallyIncreasingTime() instead of m_lastFrameTimeMonotonic.

BUG=701250
Review-Url: https://codereview.chromium.org/2746223003
Cr-Commit-Position: refs/heads/master@{#456646}
Committed: https://chromium.googlesource.com/chromium/src/+/04263813eccfbf85dc2143e4154b3c65b0f036fb

[alancutter (OOO until 2018), 2017-03-14 05:46:11]

Description was changed from

==========
Enable time control in SimTests

This change adds beginFrame(double time) to SimCompositor to allow
SimTests to control the time used by each frame.
This is in preparation for adding animation SimTests.

This change also fixes a bug in the beginFrame() implementation where
it used monotonicallyIncreasingTime() instead of m_lastFrameTimeMonotonic.
==========

to

==========
Enable control over frame time in SimTests

This change adds beginFrame(double time) to SimCompositor to allow
SimTests to control the time used by each frame.
This is in preparation for adding animation SimTests.

This change also fixes a bug in the beginFrame() implementation where
it used monotonicallyIncreasingTime() instead of m_lastFrameTimeMonotonic.

BUG=701250
==========

[alancutter (OOO until 2018), 2017-03-14 05:46:11]

alancutter@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2017-03-14 05:48:09]

I'm not sure we should support moving backwards in time, could we make
beginFrame() accept a delta that moves forward instead of a specific time?

[alancutter (OOO until 2018), 2017-03-14 05:54:05]

Description was changed from

==========
Enable control over frame time in SimTests

This change adds beginFrame(double time) to SimCompositor to allow
SimTests to control the time used by each frame.
This is in preparation for adding animation SimTests.

This change also fixes a bug in the beginFrame() implementation where
it used monotonicallyIncreasingTime() instead of m_lastFrameTimeMonotonic.

BUG=701250
==========

to

==========
Enable control over frame time in SimTests

This change adds beginFrame(double timeDelta) to SimCompositor to allow
SimTests to control the time progression used by each frame.
This is in preparation for adding animation SimTests.

This change also fixes a bug in the beginFrame() implementation where
it used monotonicallyIncreasingTime() instead of m_lastFrameTimeMonotonic.

BUG=701250
==========

[esprehn, 2017-03-14 05:54:12]

https://codereview.chromium.org/2746223003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/sim/SimCompositor.h (right):

https://codereview.chromium.org/2746223003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/sim/SimCompositor.h:35: SimDisplayItemList
beginFrame(double timeInSeconds);
If we make this:

(double timeInSeconds = 0.016)

with a default argument, and then make the code be += inside the function and
callers just keep passing the time to advance to that feels like better
ergonomics to me, maybe I don't understand how you plan to use this in your
testing patch though? Do you have an example?

[alancutter (OOO until 2018), 2017-03-14 05:54:13]

On 2017/03/14 at 05:48:09, esprehn wrote:
> I'm not sure we should support moving backwards in time, could we make
beginFrame() accept a delta that moves forward instead of a specific time?

Done.

[alancutter (OOO until 2018), 2017-03-14 05:55:07]

On 2017/03/14 at 05:54:12, esprehn wrote:
>
https://codereview.chromium.org/2746223003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/web/tests/sim/SimCompositor.h (right):
> 
>
https://codereview.chromium.org/2746223003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/web/tests/sim/SimCompositor.h:35: SimDisplayItemList
beginFrame(double timeInSeconds);
> If we make this:
> 
> (double timeInSeconds = 0.016)
> 
> with a default argument, and then make the code be += inside the function and
callers just keep passing the time to advance to that feels like better
ergonomics to me, maybe I don't understand how you plan to use this in your
testing patch though? Do you have an example?

Your earlier suggestion led me to the same thought. Done. (:

[esprehn, 2017-03-14 05:55:32]

lgtm

[alancutter (OOO until 2018), 2017-03-14 05:57:13]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-03-14 05:57:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 07:07:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489471033700070,
"parent_rev": "ec0d04e7c23717dd847717f9569115617535a6e9", "commit_rev":
"04263813eccfbf85dc2143e4154b3c65b0f036fb"}

[commit-bot: I haz the power, 2017-03-14 07:09:16]

Description was changed from

==========
Enable control over frame time in SimTests

This change adds beginFrame(double timeDelta) to SimCompositor to allow
SimTests to control the time progression used by each frame.
This is in preparation for adding animation SimTests.

This change also fixes a bug in the beginFrame() implementation where
it used monotonicallyIncreasingTime() instead of m_lastFrameTimeMonotonic.

BUG=701250
==========

to

==========
Enable control over frame time in SimTests

This change adds beginFrame(double timeDelta) to SimCompositor to allow
SimTests to control the time progression used by each frame.
This is in preparation for adding animation SimTests.

This change also fixes a bug in the beginFrame() implementation where
it used monotonicallyIncreasingTime() instead of m_lastFrameTimeMonotonic.

BUG=701250

Review-Url: https://codereview.chromium.org/2746223003
Cr-Commit-Position: refs/heads/master@{#456646}
Committed:
https://chromium.googlesource.com/chromium/src/+/04263813eccfbf85dc2143e4154b...
==========

[commit-bot: I haz the power, 2017-03-14 07:09:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/04263813eccfbf85dc2143e4154b...