Harmony - update Chrome Cleanup tool prompt dialog.

Harmony - update Chrome Cleanup tool prompt dialog.

Removed icon from Chrome Cleanup tool prompt dialog.
Added code to enable explicit invocation of dialog from browser_tests

BUG=652019
Review-Url: https://codereview.chromium.org/2746223002
Cr-Commit-Position: refs/heads/master@{#457774}
Committed: https://chromium.googlesource.com/chromium/src/+/27885745a25ab23665dd420b6b9443e9b2171284

[kylix_rd, 2017-03-13 20:03:20]

Description was changed from

==========
Harmony - update Chrome Cleanup tool prompt dialog.

Removed icon from Chrome Cleanup tool prompt dialog.
Added code to enable explicit invocation of dialog from browser_tests

BUG=652019
==========

to

==========
Harmony - update Chrome Cleanup tool prompt dialog.

Removed icon from Chrome Cleanup tool prompt dialog.
Added code to enable explicit invocation of dialog from browser_tests

BUG=652019
==========

[kylix_rd, 2017-03-13 20:03:21]

kylixrd@chromium.org changed reviewers:
+ mattm@chromium.org, pkasting@chromium.org

[kylix_rd, 2017-03-13 20:11:13]

The CQ bit was checked by kylixrd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 20:11:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylix_rd, 2017-03-13 20:13:56]

mattm@ - Please look over changes in c/b/safe_browsing. Added test to allow the
cleanup tool prompt dialog to be explicitly invoked using tapted@'s interactive
dialog test harness.

pkasting@ - Please review balance of changes to support Harmony work.

[commit-bot: I haz the power, 2017-03-13 21:38:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 21:38:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Kasting, 2017-03-14 00:24:21]

LGTM for now, but see concern below.

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/ui/views/har...
File chrome/browser/ui/views/harmony/harmony_layout_delegate.cc (right):

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/ui/views/har...
chrome/browser/ui/views/harmony/harmony_layout_delegate.cc:72: return false;
Hmm.  The translate mocks at
https://folio.googleplex.com/chrome-ux/mocks/413-translate-harmony/2017-revam...
show an icon for Harmony.  I'm wondering how to square this code with that mock.

[kylix_rd, 2017-03-14 18:30:42]

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/ui/views/har...
File chrome/browser/ui/views/harmony/harmony_layout_delegate.cc (right):

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/ui/views/har...
chrome/browser/ui/views/harmony/harmony_layout_delegate.cc:72: return false;
On 2017/03/14 00:24:21, Peter Kasting wrote:
> Hmm.  The translate mocks at
>
https://folio.googleplex.com/chrome-ux/mocks/413-translate-harmony/2017-revam...
> show an icon for Harmony.  I'm wondering how to square this code with that
mock.

Good question. That seems inconsistent with the overall design. I have noticed
that even the current the translate UI doesn't quite track parallel to the rest
of the UI. Why is that?

[mattm, 2017-03-14 18:46:14]

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc (right):

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc:589:
IN_PROC_BROWSER_TEST_F(SRTFetcherPromptTest, InvokeDialog_SRTError) {
Can you add a comment for this test? (could just be a reference to
docs/testing/test_browser_dialog.md)

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/srt_fetcher_win.cc (right):

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/srt_fetcher_win.cc:582:
DisplaySRTPrompt(base::FilePath());
It seems the appearance will differ depending on if filepath is empty or not, do
you need to add cases for both?

(See SRTGlobalError::GetBubbleViewAcceptButtonLabel,
SRTGlobalError::ShouldAddElevationIconToAcceptButton.

There's also SRTGlobalError::GetBubbleViewCancelButtonLabel which depends
onbubble_shown_from_menu_)

[kylix_rd, 2017-03-14 20:06:25]

The CQ bit was checked by kylixrd@chromium.org to run a CQ dry run

[kylix_rd, 2017-03-14 20:06:33]

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc (right):

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc:589:
IN_PROC_BROWSER_TEST_F(SRTFetcherPromptTest, InvokeDialog_SRTError) {
On 2017/03/14 18:46:14, mattm wrote:
> Can you add a comment for this test? (could just be a reference to
> docs/testing/test_browser_dialog.md)

Done.

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/srt_fetcher_win.cc (right):

https://codereview.chromium.org/2746223002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/srt_fetcher_win.cc:582:
DisplaySRTPrompt(base::FilePath());
On 2017/03/14 18:46:14, mattm wrote:
> It seems the appearance will differ depending on if filepath is empty or not,
do
> you need to add cases for both?
> 
> (See SRTGlobalError::GetBubbleViewAcceptButtonLabel,
> SRTGlobalError::ShouldAddElevationIconToAcceptButton.
> 
> There's also SRTGlobalError::GetBubbleViewCancelButtonLabel which depends
> onbubble_shown_from_menu_)
>  

Done.

[commit-bot: I haz the power, 2017-03-14 20:07:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 21:15:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 21:15:41]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-03-16 22:38:57]

lgtm

[kylix_rd, 2017-03-17 14:06:01]

The CQ bit was checked by kylixrd@chromium.org

[kylix_rd, 2017-03-17 14:06:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2746223002/#ps20001
(title: "Added test with a file")

[commit-bot: I haz the power, 2017-03-17 14:06:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 15:33:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489759561660370,
"parent_rev": "f4a66e3215736c4df4e10ad5868b7c7174c6778f", "commit_rev":
"27885745a25ab23665dd420b6b9443e9b2171284"}

[commit-bot: I haz the power, 2017-03-17 15:34:22]

Description was changed from

==========
Harmony - update Chrome Cleanup tool prompt dialog.

Removed icon from Chrome Cleanup tool prompt dialog.
Added code to enable explicit invocation of dialog from browser_tests

BUG=652019
==========

to

==========
Harmony - update Chrome Cleanup tool prompt dialog.

Removed icon from Chrome Cleanup tool prompt dialog.
Added code to enable explicit invocation of dialog from browser_tests

BUG=652019

Review-Url: https://codereview.chromium.org/2746223002
Cr-Commit-Position: refs/heads/master@{#457774}
Committed:
https://chromium.googlesource.com/chromium/src/+/27885745a25ab23665dd420b6b94...
==========

[commit-bot: I haz the power, 2017-03-17 15:34:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/27885745a25ab23665dd420b6b94...