Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2746163002: Disconnect from the READY_TO_PAY service after query. (Closed)

Created:
3 years, 9 months ago by please use gerrit instead
Modified:
3 years, 9 months ago
Reviewers:
gogerald1
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disconnect from the READY_TO_PAY service after query. BUG=700923 Review-Url: https://codereview.chromium.org/2746163002 Cr-Commit-Position: refs/heads/master@{#457580} Committed: https://chromium.googlesource.com/chromium/src/+/6900db6107a70271dad8c6623464301dc1dbd5ed

Patch Set 1 #

Patch Set 2 : Add a timeout. #

Total comments: 4

Patch Set 3 : Comments #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -35 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java View 1 2 7 chunks +47 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
please use gerrit instead
Ganggui, ptal.
3 years, 9 months ago (2017-03-13 15:07:40 UTC) #2
gogerald1
https://codereview.chromium.org/2746163002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java (right): https://codereview.chromium.org/2746163002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java#newcode161 chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:161: ContextUtils.getApplicationContext().bindService( bindService returns a boolean to indicate whether the ...
3 years, 9 months ago (2017-03-13 16:05:27 UTC) #3
please use gerrit instead
https://codereview.chromium.org/2746163002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java (right): https://codereview.chromium.org/2746163002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java#newcode161 chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:161: ContextUtils.getApplicationContext().bindService( On 2017/03/13 16:05:27, gogerald1 wrote: > bindService returns ...
3 years, 9 months ago (2017-03-15 14:00:05 UTC) #4
please use gerrit instead
Ganggui, ptal patch 3.
3 years, 9 months ago (2017-03-15 14:11:26 UTC) #5
gogerald1
lgtm
3 years, 9 months ago (2017-03-15 14:13:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746163002/60001
3 years, 9 months ago (2017-03-16 20:52:34 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 22:15:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6900db6107a70271dad8c6623464...

Powered by Google App Engine
This is Rietveld 408576698