Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2746153006: Disable some Keysystem tests (Closed)

Created:
3 years, 9 months ago by sgurun-gerrit only
Modified:
3 years, 9 months ago
Reviewers:
xhwang
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable some Keysystem tests Some of the KeySystem tests are failing for PlzNavigate on bots but they are failing on other devices. The tests actually seem to be testing device specific details and probably suffer from other issues as they are flaky when testing on a local device. Disabling them, but we need further work to decide what to do with these KeySystem tests in general. BUG=701916 Review-Url: https://codereview.chromium.org/2746153006 Cr-Commit-Position: refs/heads/master@{#457258} Committed: https://chromium.googlesource.com/chromium/src/+/5f0c6369ddc50e46aeb96c01b6ab54b55d902e11

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sgurun-gerrit only
On 2017/03/15 19:18:49, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:xhwang@chromium.org ptal, thanks!
3 years, 9 months ago (2017-03-15 19:18:58 UTC) #3
xhwang
lgtm % comments https://codereview.chromium.org/2746153006/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java File android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java (right): https://codereview.chromium.org/2746153006/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java#newcode108 android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java:108: @DisabledTest Can you add links to ...
3 years, 9 months ago (2017-03-15 19:27:06 UTC) #4
sgurun-gerrit only
https://codereview.chromium.org/2746153006/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java File android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java (right): https://codereview.chromium.org/2746153006/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java#newcode108 android_webview/javatests/src/org/chromium/android_webview/test/KeySystemTest.java:108: @DisabledTest On 2017/03/15 19:27:06, xhwang_slow wrote: > Can you ...
3 years, 9 months ago (2017-03-15 22:12:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746153006/20001
3 years, 9 months ago (2017-03-15 22:14:36 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 23:17:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5f0c6369ddc50e46aeb96c01b6ab...

Powered by Google App Engine
This is Rietveld 408576698